🌱 Update CAPI to v1.2.1 #1602
🌱 Update CAPI to v1.2.1 #1602
Conversation
k8s-ci-robot
added
cncf-cla: yes
srm09
force-pushed
the
update-capi-v1.2.0
branch
2 times, most recently
from
6061c1f to
0288c00
Compare
k8s-ci-robot
added
size/XXL
srm09
force-pushed
the
update-capi-v1.2.0
branch
8 times, most recently
from
6761144 to
f463ffa
Compare
|
/retest |
srm09
force-pushed
the
update-capi-v1.2.0
branch
from
f463ffa to
07460fe
Compare
- Updates golang version to 1.18.x Signed-off-by: Sagar Muchhal <[email protected]>
srm09
force-pushed
the
update-capi-v1.2.0
branch
from
07460fe to
79f780b
Compare
srm09
force-pushed
the
update-capi-v1.2.0
branch
2 times, most recently
from
f226084 to
8c64ff8
Compare
srm09
force-pushed
the
update-capi-v1.2.0
branch
from
8c64ff8 to
a43e00e
Compare
|
/retest |
| @@ -15,3 +15,236 @@ require ( | |||
| sigs.k8s.io/kustomize/kustomize/v4 v4.4.0 | |||
| sigs.k8s.io/testing_frameworks v0.1.2 | |||
| ) | |||
|
|
|||
| require ( | |||
| 4d63.com/gochecknoglobals v0.1.0 // indirect | |||
There was a problem hiding this comment.
is this intake expected? all coming from golangci-lint?
There was a problem hiding this comment.
Most of them are because we updated the golang version to 1.18 which basically brings in the Module graph pruning changes (from [email protected])
| @@ -246,10 +246,9 @@ func defaultKubeadmInitSpec(files []bootstrapv1.File) bootstrapv1.KubeadmConfigS | |||
| }, | |||
| ControllerManager: defaultControlPlaneComponent(), | |||
| }, | |||
| Users: defaultUsers(), | |||
| PreKubeadmCommands: defaultPreKubeadmCommands(), | |||
| UseExperimentalRetryJoin: true, | |||
There was a problem hiding this comment.
why did we drop UseExperimentalRetryJoin it's still needed in slow/flaky envs
There was a problem hiding this comment.
This has been deprecated in kubeadmconfig types. Checkout https://github.com/kubernetes-sigs/cluster-api/blob/8b4214d72762394144b83dd6d14986ff7e274095/bootstrap/kubeadm/api/v1beta1/kubeadmconfig_types.go#L100-L101
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yastij The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
- Also updates the golang linter version to v1.47.3 - Ignores lintering for deprecated API types Signed-off-by: Sagar Muchhal <[email protected]> temp commit for linters
This introdcues the use of logging via component-base/logs which is in line with the upstream Kubernetes community. Signed-off-by: Sagar Muchhal <[email protected]>
In k8s 1.24, kubeadm adds the label `node-role.kubernetes.io/control-plane` to the control plane nodes. To deploy CAPV to 1.24 k8s clusters, the toleration needs to be added to the CAPV deployment to support running the controllers on 1.24 control plane nodes. Signed-off-by: Sagar Muchhal <[email protected]>
Signed-off-by: Sagar Muchhal <[email protected]>
Signed-off-by: Sagar Muchhal <[email protected]>
srm09
force-pushed
the
update-capi-v1.2.0
branch
from
a43e00e to
1dbb057
Compare
|
@srm09: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This is a subset of the changes in the PR kubernetes-sigs#1602 that was merged in the main branch. This specifically updates the feature gate import so that we are not by default exposing the CAPI feature flags on CAPV which are not usable. This is needed since node anti affinity and node labeling functionalities are under separate and 2 new feature flags Signed-off-by: Sagar Muchhal <[email protected]>
This is a subset of the changes in the PR kubernetes-sigs#1602 that was merged in the main branch. This specifically updates the feature gate import so that we are not by default exposing the CAPI feature flags on CAPV which are not usable. This is needed since node anti affinity and node labeling functionalities are under separate and 2 new feature flags Signed-off-by: Sagar Muchhal <[email protected]>
What this PR does / why we need it:
This patch updates the CAPI version used by CAPV to
v1.2.1. Following is the summary of all the changes:VSphereMachineTemplateto support SSA and dry runs.Which issue(s) this PR fixes:
Fixes #1572
Special notes for your reviewer:
The e2e test for SSA does not exercise the changes for SSA currently, since we are waiting for kubernetes-sigs/cluster-api#7134 to be merged, added a TODO to describe the change.
Release note: