🌱 Update Calico in e2e tests to v3.24.0

[johananl]

What this PR does / why we need it: This PR updates the Calico manifest used by the e2e tests to v3.24.0. It also fixes #1605.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1605

Special notes for your reviewer:

This is a large diff. To ensure it is up to date with upstream, run the following:

curl https://raw.githubusercontent.com/johananl/cluster-api-provider-vsphere/johananl/e2e-update-calico/test/e2e/data/cni/calico/calico.yaml > pr.yaml
curl https://raw.githubusercontent.com/projectcalico/calico/v3.24.0/manifests/calico.yaml > upstream.yaml
diff upstream.yaml pr.yaml && echo "OK"

To test this PR, follow the reproduction instructions of #1605 and ensure the pods converge.

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Update Calico to `v3.24.0` in e2e tests.

[srm09]

Use quay.io prefix URLs for images instead of the docker.io URLs since they are rate limited.

[johananl]

Use quay.io prefix URLs for images instead of the docker.io URLs since they are rate limited.

Good point, thanks. I can see that the Calico maintainers have switched to quay.io as the official registry lately. Looks like they're going to update the manifests soon, too, so hopefully next time we shouldn't have to manually patch the official manifests.

For the record, here is what I used to switch to Quay in this PR:

sed -i 's/image: docker.io/image: quay.io/g' test/e2e/data/cni/calico/calico.yaml

[johananl]

The registry has been updated to quay.io @srm09.

[johananl]

Broken CI is fixed in #1608 #1602.

[johananl]

/hold

[srm09]

/retitle 🌱 Update Calico in e2e tests to v3.24.0

[randomvariable]

looks like the test failure is unrelated?
/override pull-cluster-api-provider-vsphere-test

probably don't have permissions to do that.

[randomvariable]

/lgtm

[srm09]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: srm09

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [srm09]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[srm09]

/unhold

[johananl]

looks like the test failure is unrelated? /override pull-cluster-api-provider-vsphere-test

probably don't have permissions to do that.

The broken CI is indeed unrelated to this change (see my comment above). We are waiting for #1602 to get merged.

[srm09]

/retest