-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 test/e2e: Extend ClusterClass changes test to cover InfrastructureMachineTemplate rotation #7134
🌱 test/e2e: Extend ClusterClass changes test to cover InfrastructureMachineTemplate rotation #7134
Conversation
/test pull-cluster-api-e2e-full-main |
LGTM |
InfrastructureMachineTemplate rotation Signed-off-by: Stefan Büringer [email protected]
8663365
to
111a268
Compare
/lgtm |
/test pull-cluster-api-e2e-full-main Should actually run the test.. :) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.2 |
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sbueringer: #7134 failed to apply on top of branch "release-1.2":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
This PR extends the ClusterClass changes e2e test to cover InfrastructureMachineTemplate rotation. This makes it easy to test if the webhook change for ClusterClass SSA has been implemented correctly.
xref: https://cluster-api.sigs.k8s.io/developer/providers/v1.1-to-v1.2.html#required-api-changes-for-providers (2nd point)
I would like to cherry-pick this in to release-1.2 to make it directly available to providers adopting CAPI v1.2
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #