Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Removes thumbprint value from the CI config #1600

Merged
merged 1 commit into from
Sep 9, 2022
Merged

🌱 Removes thumbprint value from the CI config #1600

merged 1 commit into from
Sep 9, 2022

Conversation

srm09
Copy link
Contributor

@srm09 srm09 commented Aug 18, 2022

What this PR does / why we need it:
This value now gets plumbed through the CI job which pulls it in from an external secret. This will reduce the need for rebasing existing PRs when the CI config changes.
Ref: kubernetes/test-infra#27168

Which issue(s) this PR fixes :
Fixes n/a

Special notes for your reviewer:
n/a

Release note:

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2022
@k8s-ci-robot k8s-ci-robot requested review from vrabbi and yastij August 18, 2022 21:17
@srm09
Copy link
Contributor Author

srm09 commented Aug 18, 2022

Waiting for the ref'd test-infra PR to be merged.

@srm09
Copy link
Contributor Author

srm09 commented Aug 31, 2022

/retitle 🌱 Removes thumbprint value from the CI config

@k8s-ci-robot k8s-ci-robot changed the title 🌱 WIP: Removes thumbprint value from the config 🌱 Removes thumbprint value from the CI config Aug 31, 2022
@srm09 srm09 marked this pull request as ready for review August 31, 2022 23:16
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2022
@srm09 srm09 added this to the v1.4.0 milestone Aug 31, 2022
@srm09 srm09 force-pushed the ci/remove-thumbprint branch from df9bb3b to 8eb90a6 Compare August 31, 2022 23:26
@srm09
Copy link
Contributor Author

srm09 commented Sep 1, 2022

/retest

@srm09
Copy link
Contributor Author

srm09 commented Sep 1, 2022 •
edited
Loading

/approve

Since the e2e test job passed even when removing the vCenter thumbprint from the CI config, this change works.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: srm09

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2022
@srm09
Copy link
Contributor Author

srm09 commented Sep 2, 2022

/override pull-cluster-api-provider-vsphere-test
Since this has nothing to do with the linter changes which are fixed in #1602

@yastij yastij self-assigned this Sep 7, 2022
@srm09
Removes thumbprint value from the config
b87bd28 
This value now gets plumbed through the CI job which pulls it in from an
external secret. Ref: kubernetes/test-infra#27168

Signed-off-by: Sagar Muchhal <[email protected]>
@srm09 srm09 force-pushed the ci/remove-thumbprint branch from 8eb90a6 to b87bd28 Compare September 9, 2022 06:38
@geetikabatra
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit ee374d1 into kubernetes-sigs:main Sep 9, 2022
@srm09 srm09 mentioned this pull request Apr 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrabbi vrabbi Awaiting requested review from vrabbi

@yastij yastij Awaiting requested review from yastij

Assignees

@yastij yastij

@geetikabatra geetikabatra

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@srm09 @k8s-ci-robot @geetikabatra @yastij