Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.4.0 (v1alpha4) #745

Closed
3 tasks done
sbueringer opened this issue Feb 19, 2021 · 17 comments
Closed
3 tasks done

v0.4.0 (v1alpha4) #745

sbueringer opened this issue Feb 19, 2021 · 17 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@sbueringer
Copy link
Member

sbueringer commented Feb 19, 2021

/kind feature

v1alpha4 implementation is on the main branch now. This issue will provide an overview of open tasks until the v1alpha4 release:

Postponed to v0.5+:

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 19, 2021
@sbueringer
Copy link
Member Author

/assign

@sbueringer
Copy link
Member Author

@jichenjc @hidekazuna
If you want and have some time. The v1alpha4 PR is ready for review: #748

I'm still fighting a bit with OpenLab but I already had green conformance test and only had a minor issue left regarding cluster delete. But now it fails, imho because of random reboots of OpenLab servers. But I think fixing those issues (and probably just retrying a lot) won't lead to a lot of changes on the PR.

@sbueringer
Copy link
Member Author

I would keep this issue for now to track further work regarding v1alpha4. Afaik the plan is to release cluster-api v1alpha4 in a few weeks.

@sbueringer
Copy link
Member Author

Current plan is to release CAPI v1alpha4 in June. I keep this issue for an overview over ongoing implementations for v1alpha4. Currently, there is nothing to do.

@sbueringer sbueringer changed the title v1alpha4 Implementation v1alpha4 Overview Apr 9, 2021
@sbueringer sbueringer pinned this issue Jun 30, 2021
@sbueringer sbueringer changed the title v1alpha4 Overview v0.4.0 (v1alpha4) Jun 30, 2021
@sbueringer
Copy link
Member Author

sbueringer commented Jun 30, 2021

As written in Slack. We will probably release next week.

@hidekazuna
Copy link
Contributor

Since CAPI v0.4.0 has been released, does not include kubernetes-sigs/cluster-api#4514, I think we can release v0.4.0 does not care kubernetes-sigs/cluster-api#4514.

@jichenjc
Copy link
Contributor

Since CAPI v0.4.0 has been released, does not include kubernetes-sigs/cluster-api#4514, I think we can release v0.4.0 does not care kubernetes-sigs/cluster-api#4514.

is it mandatory? If it's an enhancement we can always have 0.4.1 + ?

@sbueringer
Copy link
Member Author

If we got the code ready I would really prefer merging it before. Afaik it's absolutely intended to be binding for v1alpha4. Otherwise imho they would have to wait probably until v1alpha5/v1beta1 with a change like this.

And I would much rather imnplement this in CAPO v0.4.0 then have a breaking change in v0.4.1

@jichenjc
Copy link
Contributor

If we got the code ready I would really prefer merging it before. Afaik it's absolutely intended to be binding for v1alpha4. Otherwise imho they would have to wait probably until v1alpha5/v1beta1 with a change like this.

And I would much rather imnplement this in CAPO v0.4.0 then have a breaking change in v0.4.1

not realize it's a breaking change ,if it is, then yes, definitely need wait

@sbueringer
Copy link
Member Author

@jichenjc I think it's a breaking change because we change fields in the InfraCluster CRD. It's somewhat mitigated between v0.3.0 and v0.4.0 with the conversion. But I don't want to implement a conversion webhook for v0.4.0 to v0.4.1 (and I don't know if it's possible :)).

@hidekazuna
Copy link
Contributor

We are now beta mode then we wait for the following PRs?

/cc @Xenwar @iamemilio @tobiasgiese

@tobiasgiese
Copy link
Member

@hidekazuna I will push the last commits of my PR in a few seconds and remove the WIP label. Then it should be ready to merge the next days.

@tobiasgiese
Copy link
Member

tobiasgiese commented Jul 15, 2021

I created an issue regarding the readme.
We should update it before we‘re releasing to have the correct readme in the release archive.
WDYT @hidekazuna @jichenjc

@hidekazuna
Copy link
Contributor

We are now beta mode then we wait for the following PRs?

* [✨ Add conversion for SecretReference to string #937](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/937) for following  [Provide more prescriptive guidance on multi-tenancy cluster-api#4514](https://github.com/kubernetes-sigs/cluster-api/pull/4514)

* [✨ Allow Trunk configuration at a Port level #934](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/934)

* [Apply Port Security as an Update to Ports #921](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/921)

/cc @Xenwar @iamemilio @tobiasgiese

We've decided not to wait for #934 and #921. https://kubernetes.slack.com/archives/CFKJB65G9/p1626244978144500

@tobiasgiese
Copy link
Member

tobiasgiese commented Jul 20, 2021

Further, the last PRs are merged

So we are good to release

@sbueringer
Copy link
Member Author

All done

/close

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Closing this issue.

In response to this:

All done

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer unpinned this issue Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants