Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle "cluster.x-k8s.io/managed-by" annotation #859

Closed
sbueringer opened this issue May 6, 2021 · 5 comments · Fixed by #897
Closed

Handle "cluster.x-k8s.io/managed-by" annotation #859

sbueringer opened this issue May 6, 2021 · 5 comments · Fixed by #897
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@sbueringer
Copy link
Member

/kind feature

Describe the solution you'd like
CAPI v1alpha4 introduced a mechanism to manage the cluster resource externally. This is triggered by the managed-by annotation. For more context, please see:

Anything else you would like to add:
Notes:

  • We should make sure we do all that's necessary. I'm not entirely sure if it's enough to just ignore the cluster when the annotation is set. Please read the proposal for details
  • Prereq: we need a rebase onto current CAPI before
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 6, 2021
@sbueringer sbueringer mentioned this issue May 6, 2021
3 tasks
@sbueringer
Copy link
Member Author

/help

@k8s-ci-robot
Copy link
Contributor

@sbueringer:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label May 6, 2021
@jichenjc
Copy link
Contributor

jichenjc commented May 7, 2021

@sbueringer just to confirm, this need v1alpha4 land first, correct?

@sbueringer
Copy link
Member Author

sbueringer commented May 7, 2021

@jichenjc No it just needs a rebase onto the current CAPI branch (i.e. use latest CAPI dependencies) (which I'll do later today)

@chrischdi
Copy link
Member

Also relevant discussion maybe: https://kubernetes.slack.com/archives/C8TSNPY4T/p1620749340371300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
4 participants