Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add OpenStackClusterTemplates Type #933

Merged
merged 1 commit into from
Jul 20, 2021
Merged

✨ Add OpenStackClusterTemplates Type #933

merged 1 commit into from
Jul 20, 2021

Conversation

tobiasgiese
Copy link
Member

@tobiasgiese tobiasgiese commented Jul 9, 2021 •
edited
Loading

Signed-off-by: Tobias Giese [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #931

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

Tobias Giese [email protected], Daimler TSS GmbH, legal info/Impressum

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 9, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @tobiasgiese. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 9, 2021
@tobiasgiese tobiasgiese changed the title ✨ Add OpenStackClusterTemplates CRD ✨ Add OpenStackClusterTemplates Type Jul 9, 2021
@tobiasgiese tobiasgiese force-pushed the tobiasgiese/add-openstackclustertemplate branch from 272abd1 to adbee89 Compare July 9, 2021 21:09
@jichenjc
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2021
@tobiasgiese
Copy link
Member Author

/test pull-cluster-api-provider-openstack-e2e-test

@tobiasgiese tobiasgiese force-pushed the tobiasgiese/add-openstackclustertemplate branch 2 times, most recently from ff80515 to 2177997 Compare July 10, 2021 11:38
@tobiasgiese
Copy link
Member Author

e2e tests are green and commits are squashed

@tobiasgiese
Copy link
Member Author

/test pull-cluster-api-provider-openstack-e2e-test

@tobiasgiese
Copy link
Member Author

/retest

@tobiasgiese
Copy link
Member Author

tobiasgiese commented Jul 11, 2021 •
edited
Loading

It seems to be related to #927 and will maybe be fixed with #930.
I'll stop retesting until someone reviewed it :) If findings have to be committed, a retest has to be done anyway

@tobiasgiese
Copy link
Member Author

@jichenjc @chrischdi can you please take a look here? Thanks :)

@jichenjc
Copy link
Contributor

/test pull-cluster-api-provider-openstack-e2e-test

@sbueringer
Copy link
Member

@tobiasgiese I would recommend watching kubernetes-sigs/cluster-api#4903 and waiting with merge. It probably makes sense to e.g. also implement webhooks already here.

@tobiasgiese tobiasgiese mentioned this pull request Jul 16, 2021
Closed
6 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2021
@tobiasgiese tobiasgiese changed the title ✨ Add OpenStackClusterTemplates Type WIP: ✨ Add OpenStackClusterTemplates Type Jul 16, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2021
@tobiasgiese tobiasgiese force-pushed the tobiasgiese/add-openstackclustertemplate branch from 2177997 to e6cf44e Compare July 19, 2021 20:24
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2021
@tobiasgiese tobiasgiese force-pushed the tobiasgiese/add-openstackclustertemplate branch 2 times, most recently from 9352312 to 2c08705 Compare July 19, 2021 20:27
@tobiasgiese tobiasgiese changed the title WIP: ✨ Add OpenStackClusterTemplates Type ✨ Add OpenStackClusterTemplates Type Jul 19, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2021
@tobiasgiese tobiasgiese force-pushed the tobiasgiese/add-openstackclustertemplate branch 3 times, most recently from 0bf1acf to 647f234 Compare July 19, 2021 20:54
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 19, 2021
@tobiasgiese tobiasgiese force-pushed the tobiasgiese/add-openstackclustertemplate branch 2 times, most recently from b99ff08 to 2c26bbf Compare July 19, 2021 21:01
@tobiasgiese
Copy link
Member Author

@sbueringer should now be ready for review - even if kubernetes-sigs/cluster-api#4903 is not merged yet

@tobiasgiese tobiasgiese force-pushed the tobiasgiese/add-openstackclustertemplate branch from 2c26bbf to e5c860d Compare July 19, 2021 21:50
@tobiasgiese tobiasgiese force-pushed the tobiasgiese/add-openstackclustertemplate branch from e5c860d to 0322214 Compare July 20, 2021 05:48
@sbueringer
Copy link
Member

@jichenjc I would also like to merge that one before the release if it's okay for you. Makes it possible to use CAPO v0.4.0 with ClusterClass once it's implemented in CAPI.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer, tobiasgiese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2021
@jichenjc
Copy link
Contributor

/hold cancel

let's merge this and continue the release ,appreciate the help!
@tobiasgiese

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit f07c27e into kubernetes-sigs:master Jul 20, 2021
@tobiasgiese tobiasgiese deleted the tobiasgiese/add-openstackclustertemplate branch July 20, 2021 06:49
@tobiasgiese tobiasgiese mentioned this pull request Jul 20, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidekazuna hidekazuna Awaiting requested review from hidekazuna

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add OpenStackClusterTemplate type
4 participants
@tobiasgiese @k8s-ci-robot @jichenjc @sbueringer