Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update make target when ccm test #2198

Merged

Conversation

lzhecheng
Copy link
Contributor

@lzhecheng lzhecheng commented Mar 27, 2022

Linux and Windows tests should only build images they needed instead of
build everything.

Signed-off-by: Zhecheng Li [email protected]

What type of PR is this?

What this PR does / why we need it:
Linux and Windows tests should only build images they needed instead of
build everything.

related: kubernetes-sigs/cloud-provider-azure#1358

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Cloud provider Linux and Windows tests should only build images they needed instead of
build everything.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 27, 2022
@lzhecheng lzhecheng force-pushed the windows-cloud-provider-azure branch from 340efab to 330271b Compare March 28, 2022 04:00
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 28, 2022
@lzhecheng lzhecheng force-pushed the windows-cloud-provider-azure branch from 330271b to 85bc7cb Compare March 28, 2022 06:51
Linux and Windows tests should only build images they needed instead of
build everything.

Signed-off-by: Zhecheng Li <[email protected]>
@lzhecheng lzhecheng force-pushed the windows-cloud-provider-azure branch from 85bc7cb to d76aa63 Compare March 28, 2022 08:00
@lzhecheng lzhecheng changed the title [WIP] Update make target when ccm test Update make target when ccm test Mar 28, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 28, 2022
@lzhecheng
Copy link
Contributor Author

@nilo19 @mainred PTAL.

@nilo19
Copy link
Contributor

nilo19 commented Mar 29, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2022
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @jackfrancis

Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@CecileRobertMichon
Copy link
Contributor

thanks!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2022
@lzhecheng
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 41b93f2 into kubernetes-sigs:main Mar 30, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Mar 30, 2022
@lzhecheng lzhecheng deleted the windows-cloud-provider-azure branch March 30, 2022 03:57
@lzhecheng lzhecheng restored the windows-cloud-provider-azure branch March 30, 2022 03:57
@lzhecheng
Copy link
Contributor Author

/cherrypick release-1.2

@k8s-infra-cherrypick-robot

@lzhecheng: new pull request created: #2225

In response to this:

/cherrypick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lzhecheng lzhecheng deleted the windows-cloud-provider-azure branch April 12, 2022 06:57
@lzhecheng
Copy link
Contributor Author

Fixes: #2171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants