Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e2e] Add Windows ccm-e2e and conformance tests #1358

Closed
3 tasks done
lzhecheng opened this issue Mar 27, 2022 · 4 comments · Fixed by #1359
Closed
3 tasks done

[e2e] Add Windows ccm-e2e and conformance tests #1358

lzhecheng opened this issue Mar 27, 2022 · 4 comments · Fixed by #1359
Assignees
@lzhecheng
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@lzhecheng
Copy link
Contributor

lzhecheng commented Mar 27, 2022 •
edited
Loading

What would you like to be added:

Add Windows ccm-e2e and conformance tests for master branch.

  • Makefile should support building and pusing images according to the target instead of build images of all ARCHs and OSes.
  • CAPZ script should use new make target to build and push different images according to TEST_WINDOWS variable
  • test-infra repo should add ccm-e2e and conformane tests

Why is this needed:

Windows node manager images are not tested.
@lzhecheng lzhecheng added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 27, 2022
@lzhecheng lzhecheng self-assigned this Mar 27, 2022
This was referenced Mar 27, 2022
Merged
Merged
@lzhecheng lzhecheng reopened this Mar 29, 2022
@lzhecheng
Copy link
Contributor Author

Currently blocked by CAPZ to provide an external cloud-provider-azure template.

@CecileRobertMichon
Copy link
Contributor

@lzhecheng what's the status on this? Is it done?

@lzhecheng
Copy link
Contributor Author

@CecileRobertMichon yes, it's done.
https://testgrid.k8s.io/provider-azure-cloud-provider-azure#cloud-provider-azure-ccm-windows-capz
https://testgrid.k8s.io/provider-azure-cloud-provider-azure#cloud-provider-azure-conformance-windows-capz

@CecileRobertMichon
Copy link
Contributor

cc @jackfrancis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lzhecheng lzhecheng

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support customized cnm multi-arch-os image build lzhecheng/cloud-provider-azure
2 participants
@CecileRobertMichon @lzhecheng