Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support customized cnm multi-arch-os image build #1359

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Support customized cnm multi-arch-os image build #1359

merged 1 commit into from
Mar 29, 2022

Conversation

lzhecheng
Copy link
Contributor

@lzhecheng lzhecheng commented Mar 27, 2022 •
edited by nilo19
Loading

Signed-off-by: Zhecheng Li [email protected]

What type of PR is this?

What this PR does / why we need it:

Support customized cnm multi-arch-os image build

Which issue(s) this PR fixes:

Fixes #1358

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lzhecheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2022
@coveralls
Copy link

coveralls commented Mar 27, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 80.196% when pulling 95629f5 on lzhecheng:specify-arch-os into 3380955 on kubernetes-sigs:master.

@lzhecheng lzhecheng force-pushed the specify-arch-os branch 2 times, most recently from 33e39b3 to da9c715 Compare March 28, 2022 06:51
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 28, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2022
@lzhecheng lzhecheng changed the title [WIP] Rename Makefile arch and os variables Rename Makefile arch and os variables Mar 28, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 28, 2022
@lzhecheng lzhecheng changed the title Rename Makefile arch and os variables Support customized cnm multi-arch-os image build Mar 28, 2022
@lzhecheng
Copy link
Contributor Author

@nilo19 @mainred PTAL

@lzhecheng
Copy link
Contributor Author

/test pull-cloud-provider-azure-e2e-ccm-vmss

1 similar comment
@lzhecheng
Copy link
Contributor Author

/test pull-cloud-provider-azure-e2e-ccm-vmss

@nilo19
Copy link
Contributor

nilo19 commented Mar 29, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2022
@lzhecheng
Copy link
Contributor Author

/test pull-cloud-provider-azure-e2e-ccm-vmss

@lzhecheng
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit a4a818b into kubernetes-sigs:master Mar 29, 2022
@lzhecheng
Copy link
Contributor Author

/cherrypick release-1.23

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 13, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@lzhecheng: new pull request created: #1480

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lzhecheng
Copy link
Contributor Author

/cherrypick release-1.1

@lzhecheng
Copy link
Contributor Author

/cherrypick release-1.0

@lzhecheng
Copy link
Contributor Author

/cherrypick release-0.7

@k8s-infra-cherrypick-robot
Copy link

@lzhecheng: new pull request created: #1481

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 13, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@lzhecheng: new pull request created: #1482

In response to this:

/cherrypick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Apr 13, 2022
Merged
Merged
@k8s-infra-cherrypick-robot
Copy link

@lzhecheng: new pull request created: #1483

In response to this:

/cherrypick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lzhecheng lzhecheng deleted the specify-arch-os branch December 13, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@nilo19 nilo19

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[e2e] Add Windows ccm-e2e and conformance tests
5 participants
@lzhecheng @k8s-ci-robot @coveralls @nilo19 @k8s-infra-cherrypick-robot