Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST_CCM tests should build images according to OS #2171

Closed
lzhecheng opened this issue Mar 16, 2022 · 5 comments
Closed

TEST_CCM tests should build images according to OS #2171

lzhecheng opened this issue Mar 16, 2022 · 5 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@lzhecheng
Copy link
Contributor

lzhecheng commented Mar 16, 2022 •
edited
Loading

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
For cloud-provider-azure tests, the script should build images according to the OS. Now it just builds all and it makes tests more flaky and time-consuming.
https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/scripts/ci-build-azure-ccm.sh#L53
https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cloud-provider-azure/1254/pull-cloud-provider-azure-e2e-capz/1504004061148483584/build-log.txt

We can have an environment variable like IMAGE_OS to indicate which image we need.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • cluster-api-provider-azure version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 16, 2022
@lzhecheng
Copy link
Contributor Author

/cc @CecileRobertMichon

@CecileRobertMichon
Copy link
Contributor

/help

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Mar 21, 2022
@CecileRobertMichon
Copy link
Contributor

@lzhecheng remind me, was this already done?

@lzhecheng lzhecheng mentioned this issue May 18, 2022
Merged
3 tasks
@lzhecheng
Copy link
Contributor Author

@lzhecheng remind me, was this already done?

Yes, it is done by #2198

@CecileRobertMichon CecileRobertMichon mentioned this issue Mar 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@CecileRobertMichon @lzhecheng @k8s-ci-robot