-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.2] Update make target when ccm test #2225
[release-1.2] Update make target when ccm test #2225
Conversation
…build images they needed instead of build everything. Signed-off-by: Zhecheng Li <[email protected]>
/hold |
/hold cancel |
Looking at the test-infra job specs, it seems like when we merge this cherry-pick PR we will actually be using the changes from #2198 for the first time (because no test-infra job specs that I can tell use capz @ main branch). I'm good with merging this but just want folks to be aware in case this breaks upstream tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I couldn't find any capz job that's setting |
yes I believe that is the intent of the cherry-pick, to fix the issue for cloud provider tests that use the release-1.2 branch for PR and periodic jobs
@jackfrancis do you think we could add a periodic cloud provider job that uses capz main? that way we can also test changes like #2209 when they land for cloud provider custom image jobs before the release is cut / cherry-picks happen |
@CecileRobertMichon something like this? kubernetes/test-infra#25946 |
/hold @lzhecheng let's merge kubernetes/test-infra#25946 first to validate that tests are running fine with the latest changes on main. |
@CecileRobertMichon Makes sense. |
@CecileRobertMichon the periodic job and cherry-picks PRs have been merged. |
New test-infra job passed on the first attempt! https://testgrid.k8s.io/provider-azure-cloud-provider-azure#cloud-provider-azure-master-capz-main |
great /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #2198
/assign lzhecheng