Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.2] Update make target when ccm test #2225

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #2198

/assign lzhecheng

Cloud provider Linux and Windows tests should only build images they needed instead of
build everything.

…build images they needed instead of build everything.

Signed-off-by: Zhecheng Li <[email protected]>
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Apr 12, 2022
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 12, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 12, 2022
@k8s-ci-robot k8s-ci-robot added the area/provider/azure Issues or PRs related to azure provider label Apr 12, 2022
@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Apr 12, 2022
@lzhecheng
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2022
@lzhecheng
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2022
@jackfrancis
Copy link
Contributor

Looking at the test-infra job specs, it seems like when we merge this cherry-pick PR we will actually be using the changes from #2198 for the first time (because no test-infra job specs that I can tell use capz @ main branch).

I'm good with merging this but just want folks to be aware in case this breaks upstream tests.

cc @lzhecheng @feiskyer @andyzhangx

Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shysank
Copy link
Contributor

shysank commented Apr 12, 2022

Looking at the test-infra job specs, it seems like when we merge this cherry-pick PR we will actually be using the changes from #2198 for the first time (because no test-infra job specs that I can tell use capz @ main branch).

I couldn't find any capz job that's setting TEST_CCM? It's being used in azure cpi tests. Not really sure if/how azure cloud provider tests interacts with capz, is this change required for cloud provider infra tests that use capz 1.2.x?

@CecileRobertMichon
Copy link
Contributor

is this change required for cloud provider infra tests that use capz 1.2.x?

yes I believe that is the intent of the cherry-pick, to fix the issue for cloud provider tests that use the release-1.2 branch for PR and periodic jobs

because no test-infra job specs that I can tell use capz @ main branch

@jackfrancis do you think we could add a periodic cloud provider job that uses capz main? that way we can also test changes like #2209 when they land for cloud provider custom image jobs before the release is cut / cherry-picks happen

@jackfrancis
Copy link
Contributor

@CecileRobertMichon something like this? kubernetes/test-infra#25946

@CecileRobertMichon
Copy link
Contributor

CecileRobertMichon commented Apr 12, 2022

/hold

@lzhecheng let's merge kubernetes/test-infra#25946 first to validate that tests are running fine with the latest changes on main.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2022
@lzhecheng
Copy link
Contributor

lzhecheng commented Apr 13, 2022

@CecileRobertMichon Makes sense.
Besides, this PR should be held for another reason. Those jobs on other cloud-provider-azure branches are also using CAPZ release-1.2 and they don't have the change in makefile right now. I am going to cherry-pick today.
After kubernetes/test-infra#25946 is merged and Makefile cherry-pick finished, I think we can cancel hold.

@lzhecheng
Copy link
Contributor

@CecileRobertMichon the periodic job and cherry-picks PRs have been merged.

@jackfrancis
Copy link
Contributor

@CecileRobertMichon
Copy link
Contributor

great

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit fe7aa42 into kubernetes-sigs:release-1.2 Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants