Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @fisherxu to org member #107

Merged
merged 1 commit into from
May 30, 2019
Merged

Conversation

fisherxu
Copy link
Member

@fisherxu fisherxu commented May 29, 2019

Have sent some PR to mpi-operator, will continue to work on it.

This change is Reviewable

@fisherxu
Copy link
Member Author

/assign @jlewi

@abhi-g
Copy link
Member

abhi-g commented May 29, 2019

@fisherxu Can you please post couple of links to your github PRs in kubeflow. This will help us document the contributions toward the membership.

@fisherxu
Copy link
Member Author

@fisherxu Can you please post couple of links to your github PRs in kubeflow. This will help us document the contributions toward the membership.

@abhi-g @jlewi Sure, PRs I help reviewed:
kubeflow/mpi-operator#98
PRs I authored:
kubeflow/mpi-operator#109
kubeflow/mpi-operator#110
kubeflow/pytorch-operator#168
kubeflow/training-operator#1020
kubeflow/mxnet-operator#43
kubeflow/mpi-operator#101
and some other works WIP.

Add member then I can trigger the CI :-)

Copy link
Member

@abhi-g abhi-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhi-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 85363b7 into kubeflow:master May 30, 2019
@fisherxu fisherxu deleted the patch-1 branch May 30, 2019 14:43
@fisherxu
Copy link
Member Author

@abhi-g @jlewi thanks for approvel, and will there be an invitation to add the org?

@abhi-g
Copy link
Member

abhi-g commented May 31, 2019 via email

@abhi-g
Copy link
Member

abhi-g commented May 31, 2019 via email

@fisherxu
Copy link
Member Author

@abhi-g many thanks for invite, I have join the org now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants