-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v1alpha2 MPIJob controller #98
Add v1alpha2 MPIJob controller #98
Conversation
Feel free to @ me when the PR is ready to review. |
This PR is now ready for review. Note that this controller is not completely finished yet as some tests are still failing but I do not have dedicated time for this anytime soon. I see continuous contributions from the community to v1alpha1 controller but eventually require more work to land in v1alpha2 controller so I want to wrap up this PR quickly so new contributions could land in new version of the controller going forward (avoid long-running branch). The community is welcome to help fixing the tests and I will certainly look into more if I have time. This is based on an older version ever since #95 so there are some changes that are not in this new controller yet (which could be some follow-up work by the community but keeping them here for reference later): #106 #105 #100. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thanks everyone! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is the new MPIJob controller based on the API design in #95. Still a work-in-progress but creating a PR here for any immediate feedback.
Note that I created a new folder named "controllers" that includes both
v1alpha1
andv1alpha2
MPIJob controllers.This change is