Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

add uuid to id for leader election #43

Merged
merged 2 commits into from
May 30, 2019
Merged

Conversation

fisherxu
Copy link
Member

@fisherxu fisherxu commented May 30, 2019

This change is Reviewable

@k8s-ci-robot
Copy link

Hi @fisherxu. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wackxu
Copy link
Contributor

wackxu commented May 30, 2019

/ok-to-test

@k8s-ci-robot
Copy link

@wackxu: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wackxu
Copy link
Contributor

wackxu commented May 30, 2019

/lgtm

@k8s-ci-robot
Copy link

@wackxu: changing LGTM is restricted to assignees, and only kubeflow/mxnet-operator repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@suleisl2000
Copy link
Contributor

/ok-to-test

@suleisl2000
Copy link
Contributor

/lgtm

@suleisl2000
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suleisl2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a545803 into kubeflow:master May 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants