Add leader election #110
Add leader election #110
Conversation
|
Hi @fisherxu. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| return fmt.Errorf("failed to get hostname: %v", err) | ||
| } | ||
| // add a uniquifier so that two processes on the same host don't accidentally both become active | ||
| id = id + "_" + string(uuid.NewUUID()) |
There was a problem hiding this comment.
if don't add uuid to id, when the host has same hostname, the process will all become active.
|
/assign @rongou @terrytangyuan Just add K8s leader election code, and have tested, ptal. |
|
/ok-to-test |
add uuid to id? @gaocegege |
|
@fisherxu Yeah. I think if mpi operator has the problem, then tf-operator and pytorch-operator will have the same problem, too. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change is