Get revision and service listing skeletons in. #2

sixolet · 2019-01-11T01:38:32Z

This adds the kn program, with basic commands for service and revision listing
in.

kn service list
kn revision list

They use the genericclioptions library from kubernetes to support jsonpath,
yaml, and json output. The default is to just list the names of the objects, for
now, until we add in some of the kubectl-based libraries for creating tables in
another commit.

This is deliberately bare-bones; I am looking to get the basic skeletons of how
this repository is laid out down.

No tests yet. Soon.

This adds the kn program, with basic commands for service and revision listing in. kn service list kn revision list They use the genericclioptions library from kubernetes to support jsonpath, yaml, and json output. The default is to just list the names of the objects, for now, until we add in some of the kubectl-based libraries for creating tables in another commit. This is deliberately bare-bones; I am looking to get the basic skeletons of how this repository is laid out down. No tests yet. Soon.

cppforlife · 2019-01-14T19:04:39Z

@sixolet what do you think about pattern a lot of go CLIs go with: have a cmd/kn/ directory with main.go and pkg/kn/commands/ that contains implementation of commands (similar to https://github.com/kubernetes/kubernetes/blob/master/cmd/kubectl/kubectl.go)

cppforlife · 2019-01-14T19:07:26Z

i think we should also figure out how to move some of this stuff into objects instead of global variables. i've heard for example from riff folks that they want to use CLI commands as a library as well to add more of their own commands. might be a bit cleaner.

we should also figure out how to only have one exit point (one os.Exit(1)) and propagate errors instead of just existing.

sixolet · 2019-01-14T20:44:33Z

That structure of files sounds fine and I'll make this PR so; this is just the structure generated for me by the cobra commandline, rather than something I decided was best.

I'll look at the exiting and non-global suggestions and see if they fit in this PR or a separate follow-on PR or two.

sixolet · 2019-01-15T01:48:22Z

K, I think making stuff less global is going to wait; the examples I can find of Cobra best practices all have their commands global and things initialized using module init functions. Let's have conversation about how to unglobalize stuff after this is in?

cppforlife · 2019-01-15T18:11:22Z

pkg/kn/commands/service_list.go

+		// use the current context in kubeconfig
+		config, err := clientcmd.BuildConfigFromFlags("", kubeCfgFile)
+		if err != nil {
+			panic(err.Error())


return err here

cppforlife · 2019-01-15T18:11:33Z

pkg/kn/commands/revision_list.go

+		// use the current context in kubeconfig
+		config, err := clientcmd.BuildConfigFromFlags("", kubeCfgFile)
+		if err != nil {
+			panic(err.Error())


return err here

cppforlife · 2019-01-15T18:15:23Z

I think making stuff less global is going to wait

ok. will wait for that.

the examples I can find of Cobra best practices all have their commands global and things initialized using module init functions

knctl does it the same way as kubectl

ultimately all commands are combined into root cmd:

https://github.com/cppforlife/knctl/blob/master/pkg/knctl/cmd/knctl.go

vdemeester · 2019-01-16T06:38:21Z

Agreeing with @cppforlife on the non global variable thing. In docker/cli we're doing something close to what kubectl does : pull, combined in commands.go.

That said, we can iterate in follow-ups if needed 👼

…r triggered by main.go init

cppforlife · 2019-01-17T18:34:08Z

/lgtm as a starting point.

No tests yet. Soon.

i think this should be next. writing some unit tests may actually change some of the structure.

cppforlife · 2019-01-17T18:34:46Z

/approve

vdemeester

/lgtm

knative-prow-robot · 2019-01-22T10:06:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cppforlife, sixolet, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [cppforlife,sixolet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…collection (knative#465) * define data structure to be shared across all functionalities among components, i.e. data collection, github issues tracking, and slack notification * Flaky tests reporting(Part 2): collects data for flaky tests discovery As discussed, flaky tests reporting consists of github issues tracking and slack notification, so it's important to decide a common data interface that can be easily consumable by both github issues trakcing and slack notification flows. This commit defines this data structure, plus logic of data collection. Update tools/flaky-test-reporter/main.go Co-Authored-By: chaodaiG <[email protected]> Update tools/flaky-test-reporter/main.go Co-Authored-By: chaodaiG <[email protected]> * update based on PR comments

# This is the 1st commit message: adding BUILT-IN SOURCE column for kn source list-types # The commit message knative#2 will be skipped: # changing list test to check for BUILT-IN SOURCE column # The commit message knative#3 will be skipped: # changing e2e source list test to check for BUILT-IN SOURCE column # The commit message knative#4 will be skipped: # adding CHANGELOG entry # The commit message knative#5 will be skipped: # kn source list-types: changing BUILT-IN SOURCE to BUILT-IN and moving DESCRIPTION column to the end # The commit message knative#6 will be skipped: # changing BUILT-IN SOURCE to BUILT-IN in changelog # The commit message knative#7 will be skipped: # Update CHANGELOG.adoc # # Co-authored-by: David Simansky <[email protected]> # The commit message knative#8 will be skipped: # kn source list-types: changing column header to S, values to X, and moving to second column # The commit message knative#9 will be skipped: # fixing CHANGELOG merge conflict

* # This is a combination of 9 commits. # This is the 1st commit message: adding BUILT-IN SOURCE column for kn source list-types # The commit message #2 will be skipped: # changing list test to check for BUILT-IN SOURCE column # The commit message #3 will be skipped: # changing e2e source list test to check for BUILT-IN SOURCE column # The commit message #4 will be skipped: # adding CHANGELOG entry # The commit message #5 will be skipped: # kn source list-types: changing BUILT-IN SOURCE to BUILT-IN and moving DESCRIPTION column to the end # The commit message #6 will be skipped: # changing BUILT-IN SOURCE to BUILT-IN in changelog # The commit message #7 will be skipped: # Update CHANGELOG.adoc # # Co-authored-by: David Simansky <[email protected]> # The commit message #8 will be skipped: # kn source list-types: changing column header to S, values to X, and moving to second column # The commit message #9 will be skipped: # fixing CHANGELOG merge conflict * adding BUILT-IN SOURCE column for kn source list-types

knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 11, 2019

sixolet requested a review from cppforlife January 11, 2019 02:05

Move commands to pkg, so cmd only contains minimalist main.go

8e78290

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2019

sixolet added 2 commits January 14, 2019 17:34

RunE instead of Run. The defaults on Cobra command generation are weird.

e658488

Oops forgot to change types of stuff

c85ec13

cppforlife reviewed Jan 15, 2019

View reviewed changes

Do not panic on bad config file

c200076

sixolet added 2 commits January 16, 2019 17:34

Make commands no longer global

d84a421

Make configuration initialization not static in the module, but rathe…

0bb3a40

…r triggered by main.go init

vdemeester approved these changes Jan 22, 2019

View reviewed changes

knative-prow-robot assigned vdemeester Jan 22, 2019

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2019

sixolet merged commit 38932b1 into knative:master Jan 22, 2019

maximilien mentioned this pull request Jul 15, 2019

Consider adding plugin cmds to kn --help #266

Closed

coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020

Initial config for prow and gubernator. (knative#2)

0bc40ee

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Get revision and service listing skeletons in. #2

Get revision and service listing skeletons in. #2

sixolet commented Jan 11, 2019

cppforlife commented Jan 14, 2019

cppforlife commented Jan 14, 2019

sixolet commented Jan 14, 2019

sixolet commented Jan 15, 2019

cppforlife Jan 15, 2019

cppforlife Jan 15, 2019

cppforlife commented Jan 15, 2019

vdemeester commented Jan 16, 2019

cppforlife commented Jan 17, 2019

cppforlife commented Jan 17, 2019

vdemeester left a comment

knative-prow-robot commented Jan 22, 2019

Get revision and service listing skeletons in. #2

Get revision and service listing skeletons in. #2

Conversation

sixolet commented Jan 11, 2019

cppforlife commented Jan 14, 2019

cppforlife commented Jan 14, 2019

sixolet commented Jan 14, 2019

sixolet commented Jan 15, 2019

cppforlife Jan 15, 2019

Choose a reason for hiding this comment

cppforlife Jan 15, 2019

Choose a reason for hiding this comment

cppforlife commented Jan 15, 2019

vdemeester commented Jan 16, 2019

cppforlife commented Jan 17, 2019

cppforlife commented Jan 17, 2019

vdemeester left a comment

Choose a reason for hiding this comment

knative-prow-robot commented Jan 22, 2019