Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pick up default namespace from .kube/config instead of hardcoding it in kn #7

Closed
cppforlife opened this issue Jan 17, 2019 · 3 comments · Fixed by #172
Closed

pick up default namespace from .kube/config instead of hardcoding it in kn #7

cppforlife opened this issue Jan 17, 2019 · 3 comments · Fixed by #172
Milestone
v0.2.0

Comments

@cppforlife
Copy link

No description provided.

@tzununbekov tzununbekov mentioned this issue Mar 6, 2019
Closed
@rhuss
Copy link
Contributor

rhuss commented Apr 11, 2019

Maybe also add a global --namespace option for specifying the namespace to operate on.

@maximilien
Copy link
Contributor

I like @rhuss suggestion.

@cppforlife can you elaborate on your title? Or is it simply reading the current ~/.kube/config and getting the namespace from the first context section. So in my case the namespace default from:

apiVersion: v1
clusters:
- cluster:
    certificate-authority: [redacted]
    server: [redacted]
  name: knative-demo
contexts:
- context:
    cluster: knative-demo
    namespace: default #<---- this namespace
    user: [email protected]
  name: knative-demo
current-context: knative-demo
kind: Config
...

@rhuss
Copy link
Contributor

rhuss commented Jun 6, 2019

Related to #167 I guess.

@nak3 nak3 mentioned this issue Jun 9, 2019
Merged
@rhuss rhuss added this to the v0.2.0 milestone Jun 9, 2019
knative-prow-robot pushed a commit that referenced this issue Jun 24, 2019
@nak3 @knative-prow-robot
Set current namespace from kubeconfig by default (#172)
13ff277 
* Set current namespace from kubeconfig by default

Currently kn command does not pick up namespace from kubeconfig but
hardcorded default namespace.

This patch fixes to get namespace from kubeconfig.

Fixes #7

* Use NamespaceFactory to get current namespace

* Update unit tests

* Add nil check for ClientConfig
maximilien pushed a commit to maximilien/client that referenced this issue Jul 1, 2019
@nak3 @maximilien
Set current namespace from kubeconfig by default (knative#172)
8a12c72 
* Set current namespace from kubeconfig by default

Currently kn command does not pick up namespace from kubeconfig but
hardcorded default namespace.

This patch fixes to get namespace from kubeconfig.

Fixes knative#7

* Use NamespaceFactory to get current namespace

* Update unit tests

* Add nil check for ClientConfig
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
@adrcunha @knative-prow-robot
Create a smoke test for test-infra (knative#138)
afc9980 
* Create a smoke test for test-infra

This will ensure the test infrastructure is not broken.

Fixes knative#7.

Bonus: remove the `dummy.go` file.

* Restrict unit tests to `/test`, as it's the only directory with tests
eletonia added a commit to eletonia/client that referenced this issue Mar 8, 2021
@eletonia
# This is a combination of 9 commits.
bc044cf 
# This is the 1st commit message:
adding BUILT-IN SOURCE column for kn source list-types

# The commit message knative#2 will be skipped:

#	changing list test to check for BUILT-IN SOURCE column

# The commit message knative#3 will be skipped:

#	changing e2e source list test to check for BUILT-IN SOURCE column

# The commit message knative#4 will be skipped:

#	adding CHANGELOG entry

# The commit message knative#5 will be skipped:

#	kn source list-types: changing BUILT-IN SOURCE to BUILT-IN and moving DESCRIPTION column to the end

# The commit message knative#6 will be skipped:

#	changing BUILT-IN SOURCE to BUILT-IN in changelog

# The commit message knative#7 will be skipped:

#	Update CHANGELOG.adoc
#
#	Co-authored-by: David Simansky <[email protected]>

# The commit message knative#8 will be skipped:

#	kn source list-types: changing column header to S, values to X, and moving to second column

# The commit message knative#9 will be skipped:

#	fixing CHANGELOG merge conflict
knative-prow-robot pushed a commit that referenced this issue Mar 9, 2021
@eletonia
kn source-list types: adding column to specify built-in source (#1246)
a9687c6 
* # This is a combination of 9 commits.
# This is the 1st commit message:
adding BUILT-IN SOURCE column for kn source list-types

# The commit message #2 will be skipped:

#	changing list test to check for BUILT-IN SOURCE column

# The commit message #3 will be skipped:

#	changing e2e source list test to check for BUILT-IN SOURCE column

# The commit message #4 will be skipped:

#	adding CHANGELOG entry

# The commit message #5 will be skipped:

#	kn source list-types: changing BUILT-IN SOURCE to BUILT-IN and moving DESCRIPTION column to the end

# The commit message #6 will be skipped:

#	changing BUILT-IN SOURCE to BUILT-IN in changelog

# The commit message #7 will be skipped:

#	Update CHANGELOG.adoc
#
#	Co-authored-by: David Simansky <[email protected]>

# The commit message #8 will be skipped:

#	kn source list-types: changing column header to S, values to X, and moving to second column

# The commit message #9 will be skipped:

#	fixing CHANGELOG merge conflict

* adding BUILT-IN SOURCE column for kn source list-types
Kaustubh-pande pushed a commit to Kaustubh-pande/client that referenced this issue Aug 8, 2023
@dsimansk
Use new Serving and Eventing midstreams (knative#7)
7fe1846
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2.0
3 participants
@maximilien @rhuss @cppforlife