kubectl plugin #8
Comments
|
We talked about this a bit when we were chartering the working group. A kubectl plugin is delivered as a binary in its own right; kn can be both! We're borrowing most of the kubectl libs for output and using the same lib for arg parsing, so it should feel about right.
… On Jan 19, 2019, at 10:51 AM, Steren ***@***.***> wrote:
Hi,
I have no real idea what a kubectl plugin is, but I heard of them and want to open the dialog, mostly to hear opinions and capture the rationale.
I also learnt about krew, a kubectl plugin manager.
Would it make sense to have a kubectl plugin for Knative?
If so, should it be in addition to kn? or could kn be delivered as a kubectl plugin? or should it replace kn?
Having a plugin that facilitates the usage of Knative resource could be very Kubernetes... native :)
CC @sixolet
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Thanks, that makes sense. CC @ahmetb |
|
Unless you plan on exposing That said, using https://github.com/kubernetes/cli-runtime helps you reuse the flag parsing, printing etc functionality from kubectl. I'm happy to discuss kubectl plugins anytime. But unless the client would be advertised as a kubectl subcommand, it is probably not the best fit. |
|
I actually opened this issue to discuss this point: do we need a standalone |
|
I believe we need a standalone We had some discussion on this on 04/16/2019. I have some opinions and would like to restart the discussion if others are interested. |
|
Since this issue is discussing I will present and demo a proposal during Tuesday 04/06/2019's call. |
I think one of the main motivation of the Having plugins for |
sixolet
added
the
kind/compatibility
|
Seems like the consensus is to not ship via a kubectl plugin but via a standalone binary. Closing. |
Current (only) test verifies the `e2e-tests.sh` helper script. Fixes knative#8
# This is the 1st commit message: adding BUILT-IN SOURCE column for kn source list-types # The commit message knative#2 will be skipped: # changing list test to check for BUILT-IN SOURCE column # The commit message knative#3 will be skipped: # changing e2e source list test to check for BUILT-IN SOURCE column # The commit message knative#4 will be skipped: # adding CHANGELOG entry # The commit message knative#5 will be skipped: # kn source list-types: changing BUILT-IN SOURCE to BUILT-IN and moving DESCRIPTION column to the end # The commit message knative#6 will be skipped: # changing BUILT-IN SOURCE to BUILT-IN in changelog # The commit message knative#7 will be skipped: # Update CHANGELOG.adoc # # Co-authored-by: David Simansky <[email protected]> # The commit message knative#8 will be skipped: # kn source list-types: changing column header to S, values to X, and moving to second column # The commit message knative#9 will be skipped: # fixing CHANGELOG merge conflict
* # This is a combination of 9 commits. # This is the 1st commit message: adding BUILT-IN SOURCE column for kn source list-types # The commit message #2 will be skipped: # changing list test to check for BUILT-IN SOURCE column # The commit message #3 will be skipped: # changing e2e source list test to check for BUILT-IN SOURCE column # The commit message #4 will be skipped: # adding CHANGELOG entry # The commit message #5 will be skipped: # kn source list-types: changing BUILT-IN SOURCE to BUILT-IN and moving DESCRIPTION column to the end # The commit message #6 will be skipped: # changing BUILT-IN SOURCE to BUILT-IN in changelog # The commit message #7 will be skipped: # Update CHANGELOG.adoc # # Co-authored-by: David Simansky <[email protected]> # The commit message #8 will be skipped: # kn source list-types: changing column header to S, values to X, and moving to second column # The commit message #9 will be skipped: # fixing CHANGELOG merge conflict * adding BUILT-IN SOURCE column for kn source list-types
Simply list all the test images. The previous find command included also o./vendor/knative.dev/serving/test/test_images/grpc-ping/proto which is not correct and the image build would be redundant. Co-authored-by: Martin Gencur <[email protected]>
Hi,
I have no real idea what a kubectl plugin is, but I heard of them and want to open the dialog, mostly to hear opinions and capture the rationale.
I also learnt about
krew, a kubectl plugin manager.Would it make sense to have a kubectl plugin for Knative?
If so, should it be in addition to
kn? or couldknbe delivered as a kubectl plugin? or should it replacekn?Having a kubectl plugin that facilitates the usage of Knative resources could be very Kubernetes... native :)
CC @sixolet
The text was updated successfully, but these errors were encountered: