Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move client conventions from serving repo #6

Closed
sixolet opened this issue Jan 11, 2019 · 6 comments
Closed

Move client conventions from serving repo #6

sixolet opened this issue Jan 11, 2019 · 6 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@sixolet
Copy link
Contributor

sixolet commented Jan 11, 2019

As we do that, we should conform it to the commands we plan to build in the reference CLI.
@maximilien
Copy link
Contributor

Not sure I understand this. Can you elaborate a bit when you have a second. Thx.

@rhuss
Copy link
Contributor

rhuss commented Apr 24, 2019

I guess its about moving this document to this repository.

@maximilien
Copy link
Contributor

OK cool

@sixolet sixolet added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 11, 2019
rhuss pushed a commit to rhuss/knative-client that referenced this issue Jul 16, 2019
@openshift-merge-robot
Merge pull request knative#6 from openshift/nshaikh-master-license-fix
4cdb339 
Adds missing license in yaml file
@scottilee
Copy link

Looks like this has been completed but any opposition to moving https://github.com/knative/client/tree/master/conventions inside https://github.com/knative/client/tree/master/docs?

@sixolet
Copy link
Contributor Author

sixolet commented Aug 18, 2019 via email

coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
@adrcunha @google-prow-robot
Add presubmit tests (knative#6)
24b7cdd 
* Add tests for Prow configs

Bonuses:
* fix config.yaml
* add plugins.yaml

* Add missing comment

* Added missing presubmit script

* Added missing presubmit script
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
@chaodaiG @knative-prow-robot
Flaky test reporting(part knative#6): Prow job definition for flaky t…
f923e02 
…ests reporting (knative#542)

* add prow job for flaky test reporting

* updates for PR comment

* rename to flakes-reporter

* name github and slack token more specific rather than general names
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 15, 2020
eletonia added a commit to eletonia/client that referenced this issue Mar 8, 2021
@eletonia
# This is a combination of 9 commits.
bc044cf 
# This is the 1st commit message:
adding BUILT-IN SOURCE column for kn source list-types

# The commit message knative#2 will be skipped:

#	changing list test to check for BUILT-IN SOURCE column

# The commit message knative#3 will be skipped:

#	changing e2e source list test to check for BUILT-IN SOURCE column

# The commit message knative#4 will be skipped:

#	adding CHANGELOG entry

# The commit message knative#5 will be skipped:

#	kn source list-types: changing BUILT-IN SOURCE to BUILT-IN and moving DESCRIPTION column to the end

# The commit message knative#6 will be skipped:

#	changing BUILT-IN SOURCE to BUILT-IN in changelog

# The commit message knative#7 will be skipped:

#	Update CHANGELOG.adoc
#
#	Co-authored-by: David Simansky <[email protected]>

# The commit message knative#8 will be skipped:

#	kn source list-types: changing column header to S, values to X, and moving to second column

# The commit message knative#9 will be skipped:

#	fixing CHANGELOG merge conflict
knative-prow-robot pushed a commit that referenced this issue Mar 9, 2021
@eletonia
kn source-list types: adding column to specify built-in source (#1246)
a9687c6 
* # This is a combination of 9 commits.
# This is the 1st commit message:
adding BUILT-IN SOURCE column for kn source list-types

# The commit message #2 will be skipped:

#	changing list test to check for BUILT-IN SOURCE column

# The commit message #3 will be skipped:

#	changing e2e source list test to check for BUILT-IN SOURCE column

# The commit message #4 will be skipped:

#	adding CHANGELOG entry

# The commit message #5 will be skipped:

#	kn source list-types: changing BUILT-IN SOURCE to BUILT-IN and moving DESCRIPTION column to the end

# The commit message #6 will be skipped:

#	changing BUILT-IN SOURCE to BUILT-IN in changelog

# The commit message #7 will be skipped:

#	Update CHANGELOG.adoc
#
#	Co-authored-by: David Simansky <[email protected]>

# The commit message #8 will be skipped:

#	kn source list-types: changing column header to S, values to X, and moving to second column

# The commit message #9 will be skipped:

#	fixing CHANGELOG merge conflict

* adding BUILT-IN SOURCE column for kn source list-types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maximilien @rhuss @sixolet @scottilee