Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.27] Backports for 2024-08 release cycle #10667

Merged

Conversation

brandond and others added 7 commits August 2, 2024 20:54
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit c2216a6)
Signed-off-by: Brad Davidson <[email protected]>
Make secretsencrypt page size and iteration consistent with other paginators

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 891e72f)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 21611c5)
Signed-off-by: Brad Davidson <[email protected]>
This is a partial revert of 095ecdb,
with the workaround moved into klipper-lb.

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit d4c3422)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Will <[email protected]>
(cherry picked from commit e4f3cc7)
Signed-off-by: Brad Davidson <[email protected]>
Co-authored-by: Derek Nola <[email protected]>
Signed-off-by: Will Andrews <[email protected]>
(cherry picked from commit e2179aa)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit e168438)
Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond requested a review from a team as a code owner August 2, 2024 21:02
Looking at metrics revealed the cloudprovider controller name was anempty string.

k8s.io/cloud-provider/names isn't available until 1.28, so just hardcode
it for 1.27. ref: kubernetes/kubernetes#115813

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit bffdf46)
Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond force-pushed the 2024-08-backports_release-1.27 branch from 6388c93 to 848126f Compare August 2, 2024 22:23
Copy link

codecov bot commented Aug 3, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 57 lines in your changes missing coverage. Please review.

Project coverage is 36.13%. Comparing base (e16ad17) to head (848126f).
Report is 1 commits behind head on release-1.27.

Files Patch % Lines
pkg/etcd/snapshot.go 0.00% 18 Missing ⚠️
pkg/secretsencrypt/controller.go 0.00% 14 Missing ⚠️
pkg/etcd/snapshot_controller.go 0.00% 10 Missing ⚠️
pkg/cloudprovider/servicelb.go 43.75% 8 Missing and 1 partial ⚠️
pkg/cluster/cluster.go 0.00% 1 Missing ⚠️
pkg/cluster/managed.go 0.00% 1 Missing ⚠️
pkg/cluster/storage.go 66.66% 1 Missing ⚠️
pkg/etcd/etcd.go 0.00% 1 Missing ⚠️
pkg/spegel/bootstrap.go 0.00% 1 Missing ⚠️
pkg/spegel/spegel.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (e16ad17) and HEAD (848126f). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (e16ad17) HEAD (848126f)
unittests 1 0
e2etests 7 6
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.27   #10667      +/-   ##
================================================
- Coverage         45.00%   36.13%   -8.87%     
================================================
  Files               165      162       -3     
  Lines             16706    14101    -2605     
================================================
- Hits               7519     5096    -2423     
- Misses             7905     8010     +105     
+ Partials           1282      995     -287     
Flag Coverage Δ
e2etests 36.13% <25.00%> (-9.91%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit ee0b328 into k3s-io:release-1.27 Aug 5, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants