-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pagination when listing large numbers of resources #10527
Conversation
Signed-off-by: Brad Davidson <[email protected]>
a85a3c8
to
f4cda8e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10527 +/- ##
==========================================
- Coverage 49.66% 43.37% -6.30%
==========================================
Files 179 179
Lines 14936 14943 +7
==========================================
- Hits 7418 6481 -937
- Misses 6158 7265 +1107
+ Partials 1360 1197 -163
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Make secretsencrypt page size and iteration consistent with other paginators Signed-off-by: Brad Davidson <[email protected]>
f4cda8e
to
e1f300b
Compare
Proposed Changes
Use pagination when listing large numbers of resources
etcd snapshots and secrets are the only thing we bulk list, everything else should either have a selector, or there aren't enough resource of that type to matter.
Types of Changes
enhancement
Verification
See linked issue - note that this requires a LARGE number of snapshots to make a visible difference in memory - at least 100
Testing
Linked Issues
User-Facing Change
Further Comments