Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pagination when listing large numbers of resources #10527

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

brandond
Copy link
Member

Proposed Changes

Use pagination when listing large numbers of resources

etcd snapshots and secrets are the only thing we bulk list, everything else should either have a selector, or there aren't enough resource of that type to matter.

Types of Changes

enhancement

Verification

See linked issue - note that this requires a LARGE number of snapshots to make a visible difference in memory - at least 100

Testing

Linked Issues

User-Facing Change

Further Comments

@brandond brandond requested a review from a team as a code owner July 16, 2024 00:13
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 42 lines in your changes missing coverage. Please review.

Project coverage is 43.37%. Comparing base (37830fe) to head (e1f300b).

Files Patch % Lines
pkg/etcd/snapshot.go 0.00% 18 Missing ⚠️
pkg/secretsencrypt/controller.go 0.00% 14 Missing ⚠️
pkg/etcd/snapshot_controller.go 0.00% 10 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (37830fe) and HEAD (e1f300b). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (37830fe) HEAD (e1f300b)
e2etests 9 6
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10527      +/-   ##
==========================================
- Coverage   49.66%   43.37%   -6.30%     
==========================================
  Files         179      179              
  Lines       14936    14943       +7     
==========================================
- Hits         7418     6481     -937     
- Misses       6158     7265    +1107     
+ Partials     1360     1197     -163     
Flag Coverage Δ
e2etests 36.35% <0.00%> (-10.23%) ⬇️
inttests 19.71% <0.00%> (-0.01%) ⬇️
unittests 13.34% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/secretsencrypt/controller.go Outdated Show resolved Hide resolved
Make secretsencrypt page size and iteration consistent with other paginators

Signed-off-by: Brad Davidson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants