-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.29] Backports for 2024-08 release cycle #10665
Merged
dereknola
merged 9 commits into
k3s-io:release-1.29
from
brandond:2024-08-backports_release-1.29
Aug 5, 2024
Merged
[release-1.29] Backports for 2024-08 release cycle #10665
dereknola
merged 9 commits into
k3s-io:release-1.29
from
brandond:2024-08-backports_release-1.29
Aug 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brad Davidson <[email protected]> (cherry picked from commit c2216a6) Signed-off-by: Brad Davidson <[email protected]>
Make secretsencrypt page size and iteration consistent with other paginators Signed-off-by: Brad Davidson <[email protected]> (cherry picked from commit 891e72f) Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]> (cherry picked from commit 21611c5) Signed-off-by: Brad Davidson <[email protected]>
This is a partial revert of 095ecdb, with the workaround moved into klipper-lb. Signed-off-by: Brad Davidson <[email protected]> (cherry picked from commit d4c3422) Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Will <[email protected]> (cherry picked from commit e4f3cc7) Signed-off-by: Brad Davidson <[email protected]>
Co-authored-by: Brad Davidson <[email protected]> Signed-off-by: Will Andrews <[email protected]> (cherry picked from commit 3ec086f) Signed-off-by: Brad Davidson <[email protected]>
Co-authored-by: Derek Nola <[email protected]> Signed-off-by: Will Andrews <[email protected]> (cherry picked from commit e2179aa) Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]> (cherry picked from commit e168438) Signed-off-by: Brad Davidson <[email protected]>
Looking at metrics revealed the cloudprovider controller name was anempty string. Signed-off-by: Brad Davidson <[email protected]> (cherry picked from commit bffdf46) Signed-off-by: Brad Davidson <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.29 #10665 +/- ##
================================================
- Coverage 51.66% 43.46% -8.20%
================================================
Files 165 179 +14
Lines 14332 14945 +613
================================================
- Hits 7404 6496 -908
- Misses 5565 7255 +1690
+ Partials 1363 1194 -169
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dereknola
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Backports:
Types of Changes
backports
Verification
see linked issues
Testing
Linked Issues
k8s.io/apimachinery/pkg/util/wait
#10601User-Facing Change
Further Comments