Remove deprecated use of wait. functions

[willdot]

Proposed Changes

The following functions have been deprecated (along with their replacements)

PollImmediateUntilWithContext is now PollUntilContextCancel

PollImmediateInfiniteWithContext is now PollUntilContextCancel

PollImmediateWithContext is now PollUntilContextTimeout

PollImmediate is now PollUntilContextTimeout

Since all of these functions that are being replaced as Immediate the immediate flag is being set as true.

Types of Changes

Verification

Testing

Linked Issues

#9321

User-Facing Change

Further Comments

[brandond]

Thank you! lgtm, one minor nit!

[willdot]

Thank you! lgtm, one minor nit!

Ah good catch. Committed!

[dereknola]

There is an error in the split role cluster config on this PR.

[codecov]

Codecov Report

Attention: Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.

Project coverage is 43.32%. Comparing base (37830fe) to head (2024e59).
Report is 5 commits behind head on master.

Files	Patch %	Lines
pkg/secretsencrypt/config.go	0.00%	5 Missing ⚠️
pkg/cluster/managed.go	0.00%	1 Missing ⚠️
pkg/cluster/storage.go	66.66%	1 Missing ⚠️
pkg/etcd/etcd.go	0.00%	1 Missing ⚠️
pkg/spegel/bootstrap.go	0.00%	1 Missing ⚠️
pkg/spegel/spegel.go	0.00%	1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (37830fe) and HEAD (2024e59). Click for more details.

HEAD has 3 uploads less than BASE

Flag	BASE (37830fe)	HEAD (2024e59)
e2etests	9	6

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10546      +/-   ##
==========================================
- Coverage   49.66%   43.32%   -6.34%     
==========================================
  Files         179      179              
  Lines       14936    14953      +17     
==========================================
- Hits         7418     6479     -939     
- Misses       6158     7277    +1119     
+ Partials     1360     1197     -163     

Flag	Coverage Δ
e2etests	36.28% <47.61%> (-10.29%)	⬇️
inttests	19.70% <28.57%> (-0.02%)	⬇️
unittests	13.39% <0.00%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.