Fix multiple issues with servicelb #10552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brad Davidson <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10552 +/- ##
==========================================
- Coverage 49.66% 43.25% -6.42%
==========================================
Files 179 179
Lines 14936 14943 +7
==========================================
- Hits 7418 6463 -955
- Misses 6158 7286 +1128
+ Partials 1360 1194 -166
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
force-pushed
the
fix-servicelb-labels-ipv6
branch
from
1f601d7
to
df5cbc6
Compare
dereknola
previously approved these changes
Jul 23, 2024
vitorsavian
previously approved these changes
Jul 23, 2024
This is a partial revert of 095ecdb, with the workaround moved into klipper-lb. Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
fix-servicelb-labels-ipv6
branch
from
df5cbc6
to
0821db5
Compare
vitorsavian
approved these changes
Jul 24, 2024
dereknola
approved these changes
Jul 24, 2024
This was referenced Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This is a partial revert of Fix issue with
externalTrafficPolicy: Localfor single-stack services on dual-stack nodes #9963, with the workaround for LoadBalancers crashing after updating from 1.27.3 to 1.29.3 #9949 moved into klipper-lb.Waiting on:
Types of Changes
bugfix
Verification
See linked issues
Testing
yes
Linked Issues
User-Facing Change
Further Comments