Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/v5.7.0 #1065

Merged
merged 22 commits into from
Dec 25, 2023
Merged

Release/v5.7.0 #1065

merged 22 commits into from
Dec 25, 2023

Conversation

JiaqiWang18
Copy link
Member

Description

  • Contains logic to update course evaluations for courses in 2023
  • Additional keyboards shortcuts for sidebar operations
  • UI improvements: showing course code as course name in CourseModal

spencerckhuang and others added 22 commits December 5, 2023 00:28
@spencerckhuang
SBshortcuts: added hoverdCourse state to SideBar.tsx. added useeffect…
d6e2699 
… in MasterSlot.tsx to re-color when hovered
@spencerckhuang
SBshortcuts: added isHovered param to MasterSlots created in CourseMo…
b150051 
…dalBody.tsx
@spencerckhuang
Merge branch 'develop' into feature/sidebar-keyboard-shortcut
9824446
@spencerckhuang
Merge branch 'develop' into feature/sidebar-keyboard-shortcut
1ed4582
@spencerckhuang
SBshortcuts: added event listeners for key press and basic logic to u…
8b328da 
…pdate hoveredCourseIndex
@spencerckhuang
SBshortcuts: fixed debugging statements and calls to setHoveredCourse…
f5a2f71 
…. on arrow up/down, hoveredCourse state changes appropriate to the size of masterSlotList
@spencerckhuang
SBshortcuts: changing hoveredcourse to never go out of bounds if a co…
386c350 
…urse is deleted (subtract one whenever course deleted)
@spencerckhuang
SBshortcuts: removed console.logs and updated code comments
4293c93
@spencerckhuang
SBshortcuts: added enter and backspace functionality to view/remove c…
c26b2c8 
…lasses while hovering in sidebar
@spencerckhuang
SBshortcuts: disabled scrolling in calendar using up/down arrow keys …
b32f079 
…(as to not conflict with sidebar shortcuts)
@spencerckhuang
SBshortcuts: ran prettier
ddb6d8c
@spencerckhuang
SBshortcuts: reverted unintentional changes
9b42878
@spencerckhuang
SBshortcuts: removed 'any' type declaration in Semesterly.tsx
8d6f02b
@spencerckhuang
SBshortcuts: removed unnecessary comments in Calendar.tsx
a5a3b93
@jchen324
Evaluation list: Add evaluation parsing script
e5640c6
@jchen324
Evaluation list: Modify .gitignore to track the evaluation JSON file
e648574
@jchen324
Evaluation list: Modify run_parser to digest evaluations automatically
c984728
@JiaqiWang18
Merge pull request #1062 from spencerckhuang/feature/sidebar-keyboard…
b3fda37 
…-shortcut

Feature/sidebar keyboard shortcuts
@JiaqiWang18
Merge pull request #1063 from jchen324/feature/evaluations
fa694cd 
Evaluations: Add evaluation parsing script and the resultant JSON file
@JiaqiWang18
evaluations: fix eval display for size <= 2
8efbc39
@JiaqiWang18
update evaluation docs
648c8c1
@JiaqiWang18
Merge pull request #1064 from jhuopensource/fix/eval-display-and-docs
61babb6
jchen324
jchen324 approved these changes Dec 25, 2023
View reviewed changes
Copy link

@jchen324 jchen324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JiaqiWang18 JiaqiWang18 merged commit 8b4de8c into prod Dec 25, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchen324 jchen324 jchen324 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JiaqiWang18 @jchen324 @spencerckhuang