Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluations: Add evaluation parsing script and the resultant JSON file #1063

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Evaluations: Add evaluation parsing script and the resultant JSON file #1063

merged 3 commits into from
Dec 21, 2023

Conversation

jchen324
Copy link

@jchen324 jchen324 commented Dec 21, 2023 •
edited
Loading

Description

  • The evaluation parsing script parsing/library/evals_parser.py is added.
  • The resultant JSON file from the script containing readily digestable evaluations is added.
  • build/run_parser.sh is modified to digest evaluations from parsing/schools/jhu/data/evals.json automatically everyday.

Future Work

  • Currently, the script checks all ~16,000 courses for available evaluations in a specified year. We can change this in the future to check only the courses offered in a particular year or semester for available evaluations, which can save time.

@jchen324 jchen324 added the feature-request For new feature request label Dec 21, 2023
@jchen324 jchen324 requested a review from JiaqiWang18 December 21, 2023 07:32
@jchen324 jchen324 self-assigned this Dec 21, 2023
@jchen324 jchen324 linked an issue Dec 21, 2023 that may be closed by this pull request
Update course evals #1038
Closed
1 task
@jchen324 jchen324 marked this pull request as ready for review December 21, 2023 07:40
JiaqiWang18
JiaqiWang18 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@JiaqiWang18 JiaqiWang18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, merging to develop and wait for cronjob to run and check output

@JiaqiWang18 JiaqiWang18 merged commit fa694cd into jhuopensource:develop Dec 21, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiaqiWang18 JiaqiWang18 JiaqiWang18 approved these changes

Assignees

@jchen324 jchen324

Labels
feature-request For new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update course evals
2 participants
@jchen324 @JiaqiWang18