Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Eval Display and Update Docs #1064

Merged
merged 2 commits into from
Dec 23, 2023
Merged

Conversation

JiaqiWang18
Copy link
Member

Description

Fix issue with ratings not showing up when there is less than two of them in the Course Modal
Add documentation written by @jchen324 to the sphinx doc.

return (
<div style={{ marginBottom: "-30px !important" }}>{this.props.content}</div>
);
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this block doesn't seem to be useful at all, does not render the content correctly and shows empty

Copy link

@jchen324 jchen324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JiaqiWang18 JiaqiWang18 merged commit 61babb6 into develop Dec 23, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants