Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Eval Display and Update Docs #1064

Merged
merged 2 commits into from
Dec 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 63 additions & 1 deletion docs/parsing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,70 @@ Digest
You may leave out the school code to digest all schools.


Loading Course Evaluations for JHU
**********************************

Loading JHU evaluations into Semester.ly requires two steps. First, run the selenium parser locally to crawl the evaluation HTML file and save it to a JSON file.
Then, run the digest command to load the JSON file into the database. JHU publishes evaluations for the past 5 years, so the parser will crawl the evaluations for the past 5 years and save them to a JSON file.
However, to get the evaluations for the current semester, you will need to run the parser again in the current year after the evaluations are published at the end of the semester.

Instructions for Parsing Evaluations
####################################

**Prerequisites**

Ensure your computer is using an **x86-64 architecture** since the chrome driver is only compatible with this architecture.


1. **Install Chrome in Docker Environment**
From your web container shell, execute the following script:

.. code-block:: bash

code/build/install_chrome.sh

2. **Set the Year Variable**
Modify the `year` variable in `parsing/library/evals_parser.py` to select the desired year for the evaluations.
Run the following command in the web container shell:

.. code-block:: bash

python parsing/library/evals_parser.py

.. note::Enter your **JHU email and password** when prompted.

3. **Ingestion and Digestion to Local Database**
After the ingestion process completes, the file `parsing/schools/jhu/data/evals.json` will be generated.
To digest the evaluations into the local database, run:

.. code-block:: bash

python manage.py digest jhu --types evals


Final Step for Production Database
####################################

After merging `evals.json` to production, the script `run_parser.sh` will handle the digestion of the evaluations into the production database.

Troubleshooting
###############

**Selenium or Chrome Driver Issues:**
If you encounter any issues related to Selenium or the Chrome Driver, try running the following command in the web container shell:

.. code-block:: bash

pip install -r requirements.txt

This command will install necessary dependencies that may resolve the issues

**JSON Output Generation Issues:**
If you're facing difficulties with generating JSON output, consider executing the script locally rather than in a Docker environment.


Learn More & Advanced Usage
###########################
***************************

There are advanced methods for using these tools. Detailed options can be viewed by running

Expand Down
5 changes: 0 additions & 5 deletions static/js/redux/ui/side_scroller.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@ class SideScroller extends React.Component {
}

render() {
if (this.props.content.length <= 2) {
return (
<div style={{ marginBottom: "-30px !important" }}>{this.props.content}</div>
);
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this block doesn't seem to be useful at all, does not render the content correctly and shows empty

let navItems = null;
if (this.props.navItems) {
const navs = [];
Expand Down
Loading