Feature/sidebar keyboard shortcuts #1062
Conversation
… in MasterSlot.tsx to re-color when hovered
…pdate hoveredCourseIndex
…. on arrow up/down, hoveredCourse state changes appropriate to the size of masterSlotList
…urse is deleted (subtract one whenever course deleted)
…lasses while hovering in sidebar
…(as to not conflict with sidebar shortcuts)
static/js/redux/ui/Semesterly.tsx
Outdated
| @@ -246,7 +246,7 @@ const Semesterly = () => { | |||
|
|
|||
| const SemesterlyWithErrorBoundary = withErrorBoundary(Semesterly, { | |||
| FallbackComponent: FallBack, | |||
| onError(error, info) { | |||
| onError(error: any, info: any) { | |||
There was a problem hiding this comment.
@JiaqiWang18 is this right? i just changed this since tsx was complaining about them having an any type
There was a problem hiding this comment.
this shouldn't be necessary because typescript will automatically deduce the type, and we should avoid using any in TS
There was a problem hiding this comment.
if it is still complaining, try running npm i OUTSIDE of the docker environment and reload the window because VScode uses the local node_modules for type hints and the package might be missing, causing the complain.
Just ignore it if that doesn't work.
static/js/redux/ui/Semesterly.tsx
Outdated
| @@ -246,7 +246,7 @@ const Semesterly = () => { | |||
|
|
|||
| const SemesterlyWithErrorBoundary = withErrorBoundary(Semesterly, { | |||
| FallbackComponent: FallBack, | |||
| onError(error, info) { | |||
| onError(error: any, info: any) { | |||
There was a problem hiding this comment.
this shouldn't be necessary because typescript will automatically deduce the type, and we should avoid using any in TS
static/js/redux/ui/Semesterly.tsx
Outdated
| @@ -246,7 +246,7 @@ const Semesterly = () => { | |||
|
|
|||
| const SemesterlyWithErrorBoundary = withErrorBoundary(Semesterly, { | |||
| FallbackComponent: FallBack, | |||
| onError(error, info) { | |||
| onError(error: any, info: any) { | |||
There was a problem hiding this comment.
if it is still complaining, try running npm i OUTSIDE of the docker environment and reload the window because VScode uses the local node_modules for type hints and the package might be missing, causing the complain.
Just ignore it if that doesn't work.
|
feel free to click re-request to review when ready |
Description
Change Log