Use Eclipse Temurin, not AdoptOpenJDK in publish artifact action

[MarkEWaite]

Use Eclipse Temurin, not AdoptOpenJDK in publish artifact action

The 'adopt' distribution has moved to Eclipse Temurin and won't be updated at the AdoptOpenJDK location.

The advanced usage describes the transition.

The setup-java usage provides more general purpose info.

The current Adopt version is reporting:

Run actions/setup-java@v2
Resolved Java 8.0.292+1 from tool-cache
Setting Java 8.0.292+1 as the default

Java configuration:
  Distribution: adopt
  Version: 8.0.292+1
  Path: /opt/hostedtoolcache/Java_Adopt_jdk/8.0.292-1/x64

The current Temurin version reports:

Run actions/[email protected]
Resolved Java 8.0.322+6 from tool-cache
Setting Java 8.0.322+6 as the default

Java configuration:
  Distribution: temurin
  Version: 8.0.322+6
  Path: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/8.0.322-6/x64

The upgrade from JDK 8u292 to 8u322 is a positive step, since it is using a JDK version that is 12 months newer.

Proposed changelog entries

N/A - skip changelog because there are no user visible results from this change

Proposed upgrade guidelines

N/A

Submitter checklist

• (If applicable) Jira issue is well described
• Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
  • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
• Appropriate autotests or explanation to why this change has no tests
• New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
• For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

Any

Maintainer checklist

Before the changes are marked as ready-for-merge:

• There are at least 2 approvals for the pull request and no outstanding requests for change
• Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
• Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
• Proper changelog labels are set so that the changelog can be generated automatically
• If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[basil]

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!

[jglick]

jenkinsci/file-parameters-plugin#90 (comment) I think also applicable here given

jenkins/.github/workflows/publish-release-artifact.yml

Lines 3 to 5 in abd028b

	on:
	release:
	types: [published]

[basil]

What is the purpose of reviewing a PR that has already been merged?

[jglick]

Just informational, in case the author (or anyone else) thinks it would be appropriate to file a follow-up.

(In this case I did not see this PR until after it is was merged, due to a link from a plugin PR.)

[basil]

Have you considered doing a quick glance at the PRs with the ready-for-merge label every day or two to see if you have feedback for them? If the purpose of code review is to make the code of tangibly higher quality, then leaving feedback before a pull request is merged is far more likely to achieve this outcome. To be clear, there are many valid reasons for reviewing a PR after it has been merged, such as to notify authors of serious regressions, but in cases like this where there is no regression and where the suggestion is fairly trivial, it can come across as an example of "bring me a rock" style leadership.

[jglick]

I am not familiar with that metaphor.

I do not normally attempt to follow all core PRs (or PRs in major plugins for that matter) since I simply lack the time for that sort of volume and there are already a number of diligent reviewers. This one I just stumbled across after the fact, via a link from a PR in a plugin I help maintain.