Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JENKINS-49997 - Added Unsuccessful build condition for _post_ #300

Merged
merged 3 commits into from
Nov 28, 2018
Merged

JENKINS-49997 - Added Unsuccessful build condition for _post_ #300

merged 3 commits into from
Nov 28, 2018

Conversation

joseblas
Copy link
Contributor

@joseblas joseblas requested a review from abayer November 28, 2018 09:04
@abayer abayer added this to the 1.3.4 milestone Nov 28, 2018
kshultzCB
kshultzCB requested changes Nov 28, 2018
View reviewed changes
Copy link
Contributor

@kshultzCB kshultzCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just three comments - two are copyright date nits, the other is typo in the name of a test case.

...l-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/PostStageTest.java Outdated Show resolved Hide resolved
...n/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/conditions/Unsuccessful.groovy Outdated Show resolved Hide resolved
pipeline-model-definition/src/test/resources/postStage/unsuccessful.groovy Outdated Show resolved Hide resolved
@abayer abayer merged commit 5f81a91 into master Nov 28, 2018
@dwnusbaum dwnusbaum mentioned this pull request Feb 22, 2019
Merged
@bitwiseman bitwiseman deleted the JENKINS-49997 branch November 4, 2019 19:53
MarkEWaite added a commit to MarkEWaite/pipeline-model-definition-plugin that referenced this pull request May 26, 2022
@MarkEWaite
Use Eclipse Temurin in the CD action, not AdoptOpenJDK
4f46ffa 
See jenkinsci/jenkins#6406 for more details

The 'adopt' distribution has moved to Eclipse Temurin and won't be updated at the AdoptOpenJDK location.  Switch to the Temurin distribution so that we use a current version of Java.

- Bump actions/setup-java from 2 to 3 (dependabot proposed in jenkinsci#300)
- Use Eclipse Temurin in the action, not AdoptOpenJDK

Supersedes jenkinsci#511
@MarkEWaite MarkEWaite mentioned this pull request May 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kshultzCB kshultzCB kshultzCB approved these changes

@abayer abayer abayer approved these changes

@dwnusbaum dwnusbaum Awaiting requested review from dwnusbaum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@joseblas @abayer @kshultzCB