Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jenkinsci/file-parameters-plugin#90 (comment) I think also applicable here given
jenkins/.github/workflows/publish-release-artifact.yml
Lines 3 to 5 in abd028b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of reviewing a PR that has already been merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just informational, in case the author (or anyone else) thinks it would be appropriate to file a follow-up.
(In this case I did not see this PR until after it is was merged, due to a link from a plugin PR.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you considered doing a quick glance at the PRs with the
ready-for-mergelabel every day or two to see if you have feedback for them? If the purpose of code review is to make the code of tangibly higher quality, then leaving feedback before a pull request is merged is far more likely to achieve this outcome. To be clear, there are many valid reasons for reviewing a PR after it has been merged, such as to notify authors of serious regressions, but in cases like this where there is no regression and where the suggestion is fairly trivial, it can come across as an example of "bring me a rock" style leadership.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not familiar with that metaphor.
I do not normally attempt to follow all core PRs (or PRs in major plugins for that matter) since I simply lack the time for that sort of volume and there are already a number of diligent reviewers. This one I just stumbled across after the fact, via a link from a PR in a plugin I help maintain.