Removed auto enroll checkbox from CCX coash dashboard #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amir-qayyum-arbisoft The branch you are PR'ing against (feature-pocs) has been rebased, so you'll need to rebase as well. Right now the diff on this PR is way too big. |
|
ok sure |
|
@pdpinch Done with merge base |
cewing
force-pushed
the
feature-pocs
branch
3 times, most recently
from
453cfdb
to
f9351ef
Compare
Revert hotfix for PLAT-452
This pull request makes the video player module respect
the video start/stop times specified by the instructor
as a hard start/stops, i.e. the video treats the start
time as the beginning of the video and the stop time as
the end.
Previously, the video module displayed the full
video and displayed a jquery ui slider range representing
the start and end times.
This new functionality invalidates two previous acceptance
tests for the video module:
- slider visible test
- finish time video acceptance test.
These tests are removed from the common acceptance tests.
…ping Escape curly quotes in release page table
This is invalid HTML
Enable OAuth token exchange only if OAuth provider
Fix for TNL-1639
This issue was not found sooner because the test helper used only tested for GeoIP embargoes, and neglected the user profile. An additional test has been added to test for embargoes against the country assigned to the user's profile. Additionally, variable names have been cleaned up--user replaced with username--to avoid confusion in the future.
Fixed Embargo Bug in Enrollment API
ECOM-1420 adding new field and migration file.
The Enrollment API now returns the complete URL in the user_message_url field. Returning just the path can result in 404s if the consuming code simply redirects to the value of this field without first checking to see if the hostname is included. Using the full URL solves this problem for all clients.
MA-668 Mobile Push Notification payload update
XCOM-213 XCOM-214
Update component templates, round 1
use commerce api v2.
…ashboard Fixed change email address error from student dashboard
Flag test as flaky. TNL-2083.
Update Mailchimp sync scripts to be within platform
- Remove grader(s) upon deletion of existing entrance exam - Remove grader(s) upon addition of new entrance exam
Changing sequence nav buttons from images to icon fonts
Fix indentation for course structure API example
Fix for SOL-475 (double exam grader bug)
…l-methods ECOM-1441 additional methods for skip re-verification links.
…contents-accessible-via-keyboard Visually hidden content accessible through keyboard
…_date Fixed cross icon issue on set date dialog inside schedule tab
|
Should I still review this? If so, this PR this should probably be directed toward |
|
@bdero I am going to close this one, for more detail see https://github.com/edx/edx-platform/pull/7834#issuecomment-98672768 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I removed auto enrollment checkbox from CCX coash dashboard and Inside controller
view.py/ccx_invite(request, course) I made auto_enroll true
#21