Fixed change email address error from student dashboard #7753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mlkwaqas @symbolist Please review. |
|
@awaisdar001 does your test fail without your fix? |
|
@adampalay Yes it does, it tried and checked the test with and without making the change. |
|
cool :) 👍 |
|
👍 |
awaisdar001
added a commit
that referenced
this pull request
Apr 28, 2015
Fixed change email address error from student dashboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a change email request was initiated by more than one users simultaneously, a duplicate
activation_keywas produced which produced 500 Error on server.Also wrote a Unit Test to test the behavior.
TNL-1745