MA-668 Mobile Push Notification payload update #7805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support iOS receiving the update even when in the background. Support Android detecting duplicates.
|
Jenkins test this please. |
|
@aleffert @hanningni Please review from the client perspective. |
| # 1. The push is displayed automatically | ||
| # 2. The app gets it even in the background. | ||
| # See http://stackoverflow.com/questions/19239737/silent-push-notification-in-ios-7-does-not-work | ||
| push_payload.update({ |
There was a problem hiding this comment.
Did we decide this doesn't need to go into an "aps" sub key?
There was a problem hiding this comment.
Yes. That's what you tested last thing on Friday.
|
👍 |
1 similar comment
|
👍 |
nasthagiri
added a commit
that referenced
this pull request
Apr 27, 2015
MA-668 Mobile Push Notification payload update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support iOS receiving the update even when in the background.
Support Android detecting duplicates.