Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for TNL-1639 #7663

Merged
merged 1 commit into from
Apr 14, 2015
Merged

Fix for TNL-1639 #7663

merged 1 commit into from
Apr 14, 2015

Conversation

applecool
Copy link
Contributor

Fixed a typo in the filename. Renamed the forumularesponse.yaml to formularesponse.yaml

@sarina
Copy link
Contributor

sarina commented Apr 13, 2015

@applecool : could you please make separate pull requests for separate fixes?

@openedx-webhooks
Copy link

Thanks for the pull request, @applecool! I've created OSPR-522 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ('this must be merged by XX date', and why that is)
  • partner information ('this is a course on edx.org')
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the Github pull request interface. As a reminder, our process documentation is here.

We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation and added yourself to the AUTHORS file. Please see the CONTRIBUTING file for more information.

@sarina
Copy link
Contributor

sarina commented Apr 13, 2015

ok to test

@sarina
Copy link
Contributor

sarina commented Apr 13, 2015

@applecool - You should check to make sure there's no references to the misnamed file.

@sarina
Copy link
Contributor

sarina commented Apr 13, 2015

Particularly: you should run Studio, and make sure that you can still make a Formula Response problem.

@sarina
Copy link
Contributor

sarina commented Apr 14, 2015

@applecool : I tested this locally by doing this:

In one terminal I ran paver devstack lms
In another I ran paver devstack studio

Then, I went to Studio and made a new "Math Expression Input" problem. I verified then I could see the problem in the LMS and that I could interact with this. And..... it looks good! So I am going to merge this :)

sarina added a commit that referenced this pull request Apr 14, 2015
@sarina sarina merged commit 07b7c5c into openedx:master Apr 14, 2015
@applecool
Copy link
Contributor Author

Yay! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants