-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for TNL-1639 #7663
Fix for TNL-1639 #7663
Conversation
@applecool : could you please make separate pull requests for separate fixes? |
Thanks for the pull request, @applecool! I've created OSPR-522 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will still be done via the Github pull request interface. As a reminder, our process documentation is here. We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation and added yourself to the AUTHORS file. Please see the CONTRIBUTING file for more information. |
ok to test |
@applecool - You should check to make sure there's no references to the misnamed file. |
Particularly: you should run Studio, and make sure that you can still make a Formula Response problem. |
@applecool : I tested this locally by doing this: In one terminal I ran Then, I went to Studio and made a new "Math Expression Input" problem. I verified then I could see the problem in the LMS and that I could interact with this. And..... it looks good! So I am going to merge this :) |
Yay! :) |
Fixed a typo in the filename. Renamed the forumularesponse.yaml to formularesponse.yaml