Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min version of DVC to 2.58.1 (Enable live plots for experiments running outside of the workspace) #3965

Merged
merged 2 commits into from
May 28, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented May 24, 2023

Closes #3436 & closes #3178 (I will open a new issue for the final remaining item).

Things to note:

  • Experiments running in the queue are not selected by default.
  • Experiments running in the workspace are selected by default.
  • No more selecting the workspace for an experiment running in the workspace and then moving the selection across to the experiment once it finishes.
  • Experiments running in the DVCLive-only context are not selected once the workspace run finishes (selection remains on workspace).

Demos

2 queue workers + workspace experiment

screen.recording.mov

DVCLive only

Screen.Recording.2023-05-25.at.2.25.05.pm.mov

@mattseddon mattseddon added the product PR that affects product label May 24, 2023
@mattseddon mattseddon self-assigned this May 24, 2023
@mattseddon mattseddon marked this pull request as ready for review May 25, 2023 04:28
@mattseddon mattseddon requested review from sroy3 and julieg18 as code owners May 25, 2023 04:28
@mattseddon
Copy link
Member Author

UI tests changes are related to the workspace record not being selected when an experiment is found to be running in the workspace for the first time (the experiment is selected now instead).

@mattseddon mattseddon requested a review from shcheklein May 25, 2023 04:29
@mattseddon mattseddon changed the title Enable live plots for experiments running outside of the workspace Bump min version of DVC to 2.58.1 (Enable live plots for experiments running outside of the workspace) May 25, 2023
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Nice to see the logic for experiment selection be simplified more :)

@mattseddon mattseddon enabled auto-merge (squash) May 28, 2023 22:16
@codeclimate
Copy link

codeclimate bot commented May 28, 2023

Code Climate has analyzed commit 18e6e37 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.1% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit c4b18e9 into main May 28, 2023
@mattseddon mattseddon deleted the queue-live-plots branch May 28, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plots from temporary experiments are first updated when finished Queue: wrap up e2e workflow
3 participants