Bump min version of DVC to 2.57.0 (Live share to studio config option) #3976
Conversation
mattseddon
force-pushed
the
fix-live-share
branch
from
4cc1fe8 to
cd3bd27
Compare
mattseddon
force-pushed
the
fix-live-share
branch
from
c3717c0 to
84cc8ed
Compare
| <a href="https://dvc.org/doc/user-guide/project-structure/configuration#studio"> | ||
| studio.offline | ||
| </a>{' '} | ||
| config option. |
There was a problem hiding this comment.
[F] I have added this small bit of text instead of trying to work out which config file(s) studio.offline is set in and then trying to update the appropriate level(s) of config. Much like updating the studio.token this button will only call config with the --global flag. If users want to save studio.token/studio.offline in project/local configs then they should be capable of managing this themselves. If this does however become an issue I will fix it retroactively.
There was a problem hiding this comment.
I've started the process of discussing with the DVC team how we can make this easier to deal with.
There was a problem hiding this comment.
Should we hint that were setting things globally in the note? For example, The checkbox reflects the global [studio.offline](https://dvc.org/doc/user-guide/project-structure/configuration#studio) config option.
There was a problem hiding this comment.
The text in your example isn't necessarily true. If the user has set the option at the project or local level then that option will override what we set at the global level. This is from the docs and hopefully helps to explain a bit further:
I have only added the text so that in the (rare) case that the user has set studio.offline=true at the project/local level that the user will have some chance of debugging what is going on.
In order to fully explain this I think I would need to add 2 paragraphs which IMO is not necessary at this stage for onboarding.
This issue does seem to be coming up a lot though so I think I may have to build some representation of dvc config -l --show-origin to add to the page.
mattseddon
force-pushed
the
fix-live-share
branch
from
f8f83b3 to
f40a2a1
Compare
mattseddon
force-pushed
the
fix-live-share
branch
from
f40a2a1 to
4d3d2e1
Compare
| @@ -0,0 +1,3 @@ | |||
| .smallFont { | |||
| font-size: 0.6rem; | |||
There was a problem hiding this comment.
I don't have the best eyesight, but I had to slightly squint to read this 🤣. Should we increase it a bit? Example of 0.7rem:
|
Code Climate has analyzed commit ea43536 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.1% (0.0% change). View more on Code Climate. |
1/2
main<- this <- #3987Relates to one of the checkboxes in #3864
This PR removes our custom logic for sharing experiments live to Studio if the user has a
studio.tokenconfig value set. We now correctly respect the newstudio.offlineDVC config value instead of the olddvc.studio.shareExperimentsLiveextension config value. The default behaviour is that experiments will be shared live if a token is set (as per the docs).Needs to be merged before #3965 and they'll go out together.
Demos
Checkbox updating config
Screen.Recording.2023-05-25.at.4.54.15.pm.mov
Workspace run - sharing enabled
Screen.Recording.2023-05-26.at.9.37.07.am.mov
Queue run - sharing enabled
Screen.Recording.2023-05-26.at.9.38.42.am.mov
Workspace run - sharing disabled
Screen.Recording.2023-05-26.at.9.39.23.am.mov
Queue run - sharing disabled
Screen.Recording.2023-05-26.at.9.40.05.am.mov