Skip to content

Commit

Permalink
remove more dead code
Browse files Browse the repository at this point in the history
  • Loading branch information
mattseddon committed May 25, 2023
1 parent d9719dc commit 074e485
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 30 deletions.
8 changes: 0 additions & 8 deletions extension/src/experiments/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -417,14 +417,6 @@ export class Experiments extends BaseRepository<TableData> {
return this.experiments.getSelectedRevisions()
}

public setRevisionCollected(revisions: string[]) {
this.experiments.setRevisionCollected(revisions)
}

public getFinishedExperiments() {
return this.experiments.getFinishedExperiments()
}

public getExperiments() {
return this.experiments.getExperiments()
}
Expand Down
20 changes: 0 additions & 20 deletions extension/src/experiments/model/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import {
} from '../webview/contract'
import { definedAndNonEmpty, reorderListSubset } from '../../util/array'
import {
EXPERIMENT_WORKSPACE_ID,
Executor,
ExpShowOutput,
ExperimentStatus
Expand Down Expand Up @@ -66,7 +65,6 @@ export class ExperimentsModel extends ModelWithPersistence {

private currentSorts: SortDefinition[]
private running: RunningExperiment[] = []
private finishedRunning: { [id: string]: string } = {}
private startedRunning: Set<string> = new Set()

constructor(dvcRoot: string, workspaceState: Memento) {
Expand Down Expand Up @@ -160,10 +158,6 @@ export class ExperimentsModel extends ModelWithPersistence {
return this.coloredStatus[id]
}

public unselectWorkspace() {
this.coloredStatus[EXPERIMENT_WORKSPACE_ID] = UNSELECTED
}

public hasRunningExperiment() {
return this.running.length > 0
}
Expand All @@ -176,16 +170,6 @@ export class ExperimentsModel extends ModelWithPersistence {
return this.checkpoints
}

public setRevisionCollected(revisions: string[]) {
for (const { id } of this.getExperimentsAndQueued().filter(({ label }) =>
revisions.includes(label)
)) {
if (this.finishedRunning[id]) {
delete this.finishedRunning[id]
}
}
}

public canSelect() {
return canSelect(this.coloredStatus)
}
Expand Down Expand Up @@ -424,10 +408,6 @@ export class ExperimentsModel extends ModelWithPersistence {
}))
}

public getFinishedExperiments() {
return this.finishedRunning
}

public setNbfCommitsToShow(numberOfCommitsToShow: number, branch: string) {
this.numberOfCommitsToShow[branch] = numberOfCommitsToShow
this.persistNbOfCommitsToShow()
Expand Down
2 changes: 0 additions & 2 deletions extension/src/plots/model/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,6 @@ export class PlotsModel extends ModelWithPersistence {

this.fetchedRevs = new Set(revs)

this.experiments.setRevisionCollected(revs)

this.deferred.resolve()
}

Expand Down

0 comments on commit 074e485

Please sign in to comment.