gitfs: better comply with fsspec #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
changed the title
efiop
commented
Apr 18, 2022
| if relparts == ["."]: | ||
| return () | ||
| relparts = path.split(self.sep) | ||
| if relparts and relparts[0] in (".", ""): |
There was a problem hiding this comment.
Much better to normalize the path beforehand, but our fs.path is not yet available in fsspec, so we'll get to it later.
efiop
changed the title
efiop
changed the title
efiop
changed the title
This PR makes our fs accept paths relative to the root of the repo and using / as a separator. Previous behaviour was a legacy from old dvc. Pre-requisite for making dvcfs/repofs/etc switch to the same relative repo paths and / separators.
fsspec filesystems don't yet have a notion of cwd, so "." should not be used.
Instead, we should support using fs.root_marker ("" in our case), which is
currently broken.
efiop
commented
May 2, 2022
| @@ -20,6 +20,124 @@ | |||
| from scmrepo.git.objects import GitTrie | |||
|
|
|||
|
|
|||
| class Path: | |||
There was a problem hiding this comment.
Temporary copy from dvc/fs/path.py until we get it into fsspec. Useful for handling chdirs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40