fs: detach from local filesystem #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes our fs accept paths relative to the root of the repo and using / as a separator. Previous behaviour was a legacy from old dvc. Pre-requisite for making dvcfs/repofs/etc switch to the same relative repo paths and / separators.
efiop
commented
Dec 28, 2021
| if detail: | ||
| yield ( | ||
| root, | ||
| {d: self.info(os.path.join(root, d)) for d in dirs}, | ||
| {f: self.info(os.path.join(root, f)) for f in files}, | ||
| {d: self.info(posixpath.join(root, d)) for d in dirs}, |
There was a problem hiding this comment.
For the record: Will switch to fs.path once it is introduced to fsspec.
efiop
commented
Dec 28, 2021
Comment on lines
60
to
64
| def _get_key(self, path: str) -> Tuple[str, ...]: | ||
| from scmrepo.utils import relpath | ||
|
|
||
| if os.path.isabs(path): | ||
| path = relpath(path, self.root_dir) | ||
| relparts = path.split(os.sep) | ||
| relparts = path.split(self.sep) | ||
| if relparts == ["."]: | ||
| return () | ||
| return tuple(relparts) |
There was a problem hiding this comment.
Will introduce _strip_protocol later.
skshetry
pushed a commit
that referenced
this pull request
Mar 7, 2022
This PR makes our fs accept paths relative to the root of the repo and using / as a separator. Previous behaviour was a legacy from old dvc. Pre-requisite for making dvcfs/repofs/etc switch to the same relative repo paths and / separators.
skshetry
pushed a commit
that referenced
this pull request
Mar 7, 2022
This PR makes our fs accept paths relative to the root of the repo and using / as a separator. Previous behaviour was a legacy from old dvc. Pre-requisite for making dvcfs/repofs/etc switch to the same relative repo paths and / separators.
skshetry
pushed a commit
that referenced
this pull request
Mar 19, 2022
This PR makes our fs accept paths relative to the root of the repo and using / as a separator. Previous behaviour was a legacy from old dvc. Pre-requisite for making dvcfs/repofs/etc switch to the same relative repo paths and / separators.
skshetry
pushed a commit
that referenced
this pull request
Apr 6, 2022
This PR makes our fs accept paths relative to the root of the repo and using / as a separator. Previous behaviour was a legacy from old dvc. Pre-requisite for making dvcfs/repofs/etc switch to the same relative repo paths and / separators.
efiop
added a commit
to efiop/scmrepo
that referenced
this pull request
Apr 7, 2022
This PR makes our fs accept paths relative to the root of the repo and using / as a separator. Previous behaviour was a legacy from old dvc. Pre-requisite for making dvcfs/repofs/etc switch to the same relative repo paths and / separators.
efiop
added a commit
to efiop/scmrepo
that referenced
this pull request
Apr 28, 2022
This PR makes our fs accept paths relative to the root of the repo and using / as a separator. Previous behaviour was a legacy from old dvc. Pre-requisite for making dvcfs/repofs/etc switch to the same relative repo paths and / separators.
efiop
added a commit
to efiop/scmrepo
that referenced
this pull request
May 2, 2022
This PR makes our fs accept paths relative to the root of the repo and using / as a separator. Previous behaviour was a legacy from old dvc. Pre-requisite for making dvcfs/repofs/etc switch to the same relative repo paths and / separators.
efiop
added a commit
that referenced
this pull request
May 2, 2022
This PR makes our fs accept paths relative to the root of the repo and using / as a separator. Previous behaviour was a legacy from old dvc. Pre-requisite for making dvcfs/repofs/etc switch to the same relative repo paths and / separators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes our fs accept paths relative to the root of the repo and using / as a separator.
Previous behaviour was a legacy from old dvc.
Pre-requisite for making dvcfs/repofs/etc switch to the same relative repo paths and / separators.