Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

path changes from #24 and #25 #40

Closed
wants to merge 2 commits into from
Closed

path changes from #24 and #25 #40

wants to merge 2 commits into from

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Mar 7, 2022

Reverts #39

@skshetry skshetry force-pushed the revert-39-revert-24-25 branch from 2576474 to 3819850 Compare March 7, 2022 05:42
skshetry
skshetry commented Mar 7, 2022
View reviewed changes
Copy link
Member Author

@skshetry skshetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Need to "rebase and merge" instead of squash.

@skshetry skshetry force-pushed the revert-39-revert-24-25 branch from 3819850 to dea7fd8 Compare March 7, 2022 05:52
@skshetry skshetry force-pushed the revert-39-revert-24-25 branch from dea7fd8 to a396db2 Compare March 19, 2022 03:38
efiop added 2 commits April 6, 2022 20:46
@efiop @skshetry
fs: detach from local filesystem (#24)
f29ad51 
This PR makes our fs accept paths relative to the root of the repo and using / as a separator.
Previous behaviour was a legacy from old dvc.

Pre-requisite for making dvcfs/repofs/etc switch to the same relative repo paths and / separators.
@efiop @skshetry
fs: support root_marker (#25)
8dd5580 
fsspec filesystems don't yet have a notion of cwd, so "." should not be used.
Instead, we should support using fs.root_marker ("" in our case), which is
currently broken.
@skshetry skshetry force-pushed the revert-39-revert-24-25 branch from a396db2 to 8dd5580 Compare April 6, 2022 15:01
@efiop
Copy link
Contributor

efiop commented Apr 11, 2022

Will reintroduce in a separate PR. Closing.

@efiop efiop closed this Apr 11, 2022
@efiop efiop reopened this Apr 11, 2022
@efiop efiop closed this Apr 11, 2022
@efiop efiop mentioned this pull request Apr 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skshetry @efiop