Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: support root_marker #25

Merged
merged 1 commit into from
Dec 29, 2021
Merged

fs: support root_marker #25

merged 1 commit into from
Dec 29, 2021

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Dec 29, 2021

fsspec filesystems don't yet have a notion of cwd, so "." should not be used.
Instead, we should support using fs.root_marker ("" in our case), which is
currently broken.

fsspec filesystems don't yet have a notion of cwd, so "." should not be used.
Instead, we should support using fs.root_marker ("" in our case), which is
currently broken.
@efiop efiop merged commit 42db9e4 into iterative:main Dec 29, 2021
skshetry added a commit that referenced this pull request Mar 7, 2022
skshetry added a commit that referenced this pull request Mar 7, 2022
skshetry added a commit that referenced this pull request Mar 7, 2022
skshetry pushed a commit that referenced this pull request Mar 7, 2022
fsspec filesystems don't yet have a notion of cwd, so "." should not be used.
Instead, we should support using fs.root_marker ("" in our case), which is
currently broken.
skshetry pushed a commit that referenced this pull request Mar 7, 2022
fsspec filesystems don't yet have a notion of cwd, so "." should not be used.
Instead, we should support using fs.root_marker ("" in our case), which is
currently broken.
skshetry pushed a commit that referenced this pull request Mar 19, 2022
fsspec filesystems don't yet have a notion of cwd, so "." should not be used.
Instead, we should support using fs.root_marker ("" in our case), which is
currently broken.
skshetry pushed a commit that referenced this pull request Apr 6, 2022
fsspec filesystems don't yet have a notion of cwd, so "." should not be used.
Instead, we should support using fs.root_marker ("" in our case), which is
currently broken.
efiop added a commit to efiop/scmrepo that referenced this pull request Apr 7, 2022
fsspec filesystems don't yet have a notion of cwd, so "." should not be used.
Instead, we should support using fs.root_marker ("" in our case), which is
currently broken.
efiop added a commit to efiop/scmrepo that referenced this pull request Apr 28, 2022
fsspec filesystems don't yet have a notion of cwd, so "." should not be used.
Instead, we should support using fs.root_marker ("" in our case), which is
currently broken.
efiop added a commit to efiop/scmrepo that referenced this pull request May 2, 2022
fsspec filesystems don't yet have a notion of cwd, so "." should not be used.
Instead, we should support using fs.root_marker ("" in our case), which is
currently broken.
efiop added a commit that referenced this pull request May 2, 2022
fsspec filesystems don't yet have a notion of cwd, so "." should not be used.
Instead, we should support using fs.root_marker ("" in our case), which is
currently broken.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant