-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GS experiments with dvc exp init
#3051
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if you think this direction makes sense @iesahin!
I'm copying @jorgeorpinel 's comments in Notion:
About the sentence starting with "This experiment is then associated with the values in parameters file":
|
It looks we still need to use
Is there any work to check whether we're inside a DVC repository and |
This has been deprioritized for now, so |
This one is ready for review @shcheklein @dberenbaum @jorgeorpinel @julieg18 |
tell the purpose I believe.
bef8d07
to
3369e5e
Compare
Converted to draft. Will work on these in separate branches and this will be closed after other PRs are submitted. |
#3112 modified to include |
@@ -138,6 +111,34 @@ Experiment results have been applied to your workspace. | |||
|
|||
<details> | |||
|
|||
### ℹ️ More information about (Hyper)parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is in #3163
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#3163 is merged. Should master
be merged into this branch so this change goes away, and resolve the comment?
Interesting method. Similar to a nested PR or PR series but less messy. However, it can also be confusing to review in 2 places. What's the exact use of this draft if it's split into other PRs? Should anyone be looking at the changes? What parts)? Thanks |
This is for my own tracking. For longer documents, I can rebase time to time to see the remaining parts. For this one, I don't expect any review. It's like a guide to move the document. |
This one is completed, now GS:Experiments starts with |
This one is migrated from Notion. I have added a hidden section on hyperparameters there.
I have modified here:
It starts with
dvc exp init
now. Without mentioning any pipelines stuff ordvc.yaml
I'm planning to remove "If you've run
repro
before" hidden section, the section where we tell how to prepare pipelines for arbitrary projects, and keep the hyperparameter stuff to a minimum.Closes #3072
Closes #3118
This one will be closed after merging the following small PRs:
exp init
instead ofstage add
#3196