Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start: add a section about metrics to experiments #3197

Merged
merged 3 commits into from
Feb 23, 2022

Conversation

iesahin
Copy link
Contributor

@iesahin iesahin commented Jan 19, 2022

This one adds a brief hidden section about metrics to https://dvc.org/start/experiments/

Related #3051

@iesahin iesahin self-assigned this Jan 19, 2022
@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-start-e-r8yg7c January 19, 2022 15:37 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-start-e-r8yg7c February 1, 2022 11:15 Inactive
@iesahin
Copy link
Contributor Author

iesahin commented Feb 9, 2022

This one needs a review too: @shcheklein @jorgeorpinel

@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-start-e-r8yg7c February 15, 2022 14:04 Inactive
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a good improvement. I think it makes sense to move both - params and metrics details up (close to the first time they are mentioned, may be combining them into one section)

@iesahin
Copy link
Contributor Author

iesahin commented Feb 17, 2022

I created an issue, #3296 as a follow-up. Can we merge this @jorgeorpinel ?

@iesahin iesahin merged commit 5b5e1ba into master Feb 23, 2022
@iesahin iesahin deleted the iesahin/start-exp-add-metrics branch February 23, 2022 15:55
@jorgeorpinel
Copy link
Contributor

Sorry for the delay. The section's content looks good, thanks. I would suggest moving it up earlier near where params are mentioned first (that would also avoid 2 details sections together), and in that case the last paragraph is probably unnecessary. I'll make a draft PR ⌛

jorgeorpinel added a commit that referenced this pull request Mar 1, 2022
jorgeorpinel added a commit that referenced this pull request Mar 8, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants