-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GS:Visualization and Plots #3050
Conversation
The following are @shcheklein 's comments in Notion. Some of these are more related to #3051 than this,
|
I don't intend to cover metrics here. In my plan this page will be related to plots with experiments. |
sounds good, esp considering that metrics are covered by the first part in this case |
I assume that we keep the metrics, plots, etc section in the data trail as well, right? |
@iesahin thanks Emre, that's exactly right approach to the iteration. Makes it way easier to review and get on the same page before we jump into implementation. |
added some content to this for you to see the flow concretely @shcheklein @dberenbaum |
BTW, could we remove style checks in draft PRs? @shcheklein My setup in WSL seems not to run the commit hook, and I forget to run |
I think so, there is a |
On second thought, not a big deal. Thanks. |
Regarding how to introduce dvclive, I'm not sure whether it's better as a 3rd type of plot, or as a different way to generate the other types of plots. I think it's fine in this form and we can iterate later since there's no clear right way. In case it seems more compelling, the alternative is to explain plots as data series or images, and mention dvclive briefly as the way that those plots files were generated here. This makes dvclive more of a helper utility and less of an entirely separate concept. For example:
|
content/docs/start/visualization.md
Outdated
@@ -0,0 +1,100 @@ | |||
# Visualization with DVC Plots | |||
|
|||
In parallel with versioning parameters and metrics by associating them with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Early to edit language, but this paragraph is too complicated for the intro.
- "multivariate outputs"
- DVC allows to generate plots - I think DVC also captures them, right? (keeps track)
In parallel with versioning parameters and metrics
- this means that it should go right after experiments show/run?
Looks good overall for me, Emre. One question is the right place for this + properly integrate into the project that we already use (if it's not yet). |
Do you think is it better to cover parallel coordinates plot here? @shcheklein @dberenbaum |
|
IMO no. We can't squeeze every visualization into GS, and this one is particular to comparing experiments, so it seems like an odd fit. |
I'll wait for #3051 to be reviewed/merged in separate PR before going on to this. If you think we can proceed in parallel, please let me know. @shcheklein @dberenbaum @jorgeorpinel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more suggestions. Only the last question about the dvclive image worries me a little, everything else is minor. Thanks again @iesahin -- we're almost there 👍🏼
model. You can see the report in `training_metrics/index.html` with your | ||
browser: | ||
|
||
![dvclive](/img/start_visualization_dvclive.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![dvclive](/img/start_visualization_dvclive.png) | |
![DVCLive plots](/img/start_visualization_dvclive.png) |
The image is not readable though. Can the fonts be larger?
And maybe the top part with dvclive.json sample should be a regular code block (under the image) with a few rows of the data instead of just one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same in the documentation: https://dvc.org/doc/dvclive/dvclive-with-dvc#html-report
Zooming in to make the axis labels readable makes the whole chart so large. How could we solve this @daavoo ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can still change the label as suggested for now.
same in the documentation: https://dvc.org/doc/dvclive/dvclive-with-dvc#html-report
Yes we have that problem in a few places but at least those are GIFs and you can see changing plots so maybe it doesn't matter that much that the text is readable in some other cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to create separate issue or deal with this in #3455
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be tracked in #3470
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but still the image caption could be better. It's helpful to have descriptive image captions for SEO and even image searches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Minor things I'll commit myself)
Ping 🙂 @iesahin ☝🏼 please see #3050 (review) |
Co-authored-by: Jorge Orpinel <[email protected]>
Closing in favor of #3455 |
Not a great strategy. Makes reviewing that other PR much more complicated. Removes my contributions from commit history... Etc. Let's reopen and finish this PR, and then reorganize once all the material is in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 3 review comments left to commit or decide on:
- Add GS:Visualization and Plots #3050 (comment)
- Add GS:Visualization and Plots #3050 (comment)
- Add GS:Visualization and Plots #3050 (review)
Nothing major so approving
Gatsby Cloud Build Reportdvc.org 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 3m |
OK @iesahin up to you if you want to resolve the above comments and a) close this one but copy/paste the final result into https://github.com/iterative/dvc.org/pull/3455/files#diff-e852faa513d0975fe637b21cd31c7530b2ae1d16cfd6e9e6132128c3397c9e03 or b) merge this, and then merge Whatever is easier for you. Thanks again |
Co-authored-by: Jorge Orpinel <[email protected]>
Co-authored-by: Jorge Orpinel <[email protected]>
This reverts commit 5ff8661.
* reorg #3 for trails * shortened data/ urls * renamed access * renamed pipelines * redirects from older URLs to new doc/start/data/ URLs * added trail section titles and minor revision * deleting forgotten metrics file * update visualization from #3050 * Update content/docs/sidebar.json Co-authored-by: Jorge Orpinel <[email protected]> * Update redirects-list.json Co-authored-by: Jorge Orpinel <[email protected]> * renamed to experiments * moved visualization to experiments/ * Update content/docs/start/index.md Co-authored-by: Jorge Orpinel <[email protected]> * reverting the sidebar titles * Restyled by prettier (#3471) Co-authored-by: Restyled.io <[email protected]> * renamed the directory Co-authored-by: Jorge Orpinel <[email protected]> Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <[email protected]>
This is mostly for discussion after the Notion experimentation went "we wanted the best, but it turned out like always" :)
I'll develop this as we discuss the scope of changes.
Closes #2925
Closes #3309