Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GS:Visualization and Plots #3050
Add GS:Visualization and Plots #3050
Changes from all commits
2b04b63
e865161
f6bc44e
b9013dc
07086b9
7175d17
ff00094
6771178
77dbdf5
42bf550
10e0344
b6c8b3e
1952a9b
653ffaa
219a59c
f4df213
93fdb93
925f472
7053759
b343d34
dc6a2ed
51b9820
7dd9675
07dcd51
4f3b0f1
c90918d
9a7ab68
5ff8661
6b3f660
8c9f957
29ceb79
99b4487
63af2d9
ca6ae91
fc49d48
2eb2e6a
4e6cf30
a11b4c5
3af2c42
b4ee07c
ad9b474
e894d0b
18c45f0
4ca9196
987105f
314791d
f34c59f
3b28572
a153b70
603674a
63f9dc0
4427ff3
1f70192
eb1853a
79f2bf3
4cacc6b
80af071
debec87
fcd0cd5
18274b3
2ae5379
b4681fe
6f5264d
f26f366
c1f4961
b0ed669
7e411e2
cf02e81
b2a832e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image is not readable though. Can the fonts be larger?
And maybe the top part with dvclive.json sample should be a regular code block (under the image) with a few rows of the data instead of just one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same in the documentation: https://dvc.org/doc/dvclive/dvclive-with-dvc#html-report
Zooming in to make the axis labels readable makes the whole chart so large. How could we solve this @daavoo ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can still change the label as suggested for now.
Yes we have that problem in a few places but at least those are GIFs and you can see changing plots so maybe it doesn't matter that much that the text is readable in some other cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to create separate issue or deal with this in #3455
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be tracked in #3470
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but still the image caption could be better. It's helpful to have descriptive image captions for SEO and even image searches.