Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start: bi-trail reorg #3455

Merged
merged 17 commits into from
Apr 28, 2022
Merged

start: bi-trail reorg #3455

merged 17 commits into from
Apr 28, 2022

Conversation

iesahin
Copy link
Contributor

@iesahin iesahin commented Apr 20, 2022

This is the second (or third) candidate for GS reorganization:

Compare w/ #3444

This creates another level in the sidebar, moves versioning -> data/index, makes accessing, pipelines, metrics-params-plots children of data/. Moves experiments.md to experiments/index.md and adds visualization from #3050 as a child to experiments.

  • Redirects
  • Review and Revise briefly

@iesahin iesahin marked this pull request as draft April 20, 2022 15:47
@iesahin iesahin requested a review from shcheklein April 20, 2022 15:50
@@ -0,0 +1,278 @@
---
title: 'Get Started: Metrics, Parameters, and Plots'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QQ - is it the same file as we had before or do we have some / any changes here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same file. I did minimum content changes in this PR

@iesahin
Copy link
Contributor Author

iesahin commented Apr 20, 2022 via email

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks go to me.

Do we need redirects?
Can we introduce some small corrections in the index page to explain the new structure and help people navigate? (please let's try to do it quick, non invasive :) )

@iesahin
Copy link
Contributor Author

iesahin commented Apr 21, 2022

We need redirects. I didn't change any content, will review briefly. Did you deploy this one yourself? (I mean, did you see the actual site?)

@shcheklein
Copy link
Member

No, I didn't see actual site. I was reviewing MD files here.

@gatsby-cloud
Copy link

gatsby-cloud bot commented Apr 25, 2022

Gatsby Cloud Build Report

dvc.org

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 3m

@iesahin iesahin self-assigned this Apr 25, 2022
@iesahin iesahin marked this pull request as ready for review April 25, 2022 19:44
@iesahin
Copy link
Contributor Author

iesahin commented Apr 25, 2022

I'll merge #3050 to this and merge these together.

Could you review this one? @jorgeorpinel

@jorgeorpinel jorgeorpinel changed the title start: Reorganize into Trails (Candidate #3) start: bi-trail reorg Apr 26, 2022
redirects-list.json Outdated Show resolved Hide resolved
Comment on lines 39 to 41
"label": "Data Management",
"source": "data/index.md",
"children": [
Copy link
Contributor

@jorgeorpinel jorgeorpinel Apr 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issue with adding this middle click-level is that it's possible to "get lost" in the navigation. Example: I click Get Started and read the general index. Then I only open the Data Management element in the nav (click the little arrow) *without opening its index page* and see that there's pages inside. I then assume the content starts in the first sub-page (Accessing Data) and click on that. I have now missed all of the basic info on data mgmt. Cc @shcheklein

image

@iesahin
Copy link
Contributor Author

iesahin commented Apr 27, 2022

Would you take a look at the deployment once more or could I merge this now? @shcheklein @jorgeorpinel

@iesahin
Copy link
Contributor Author

iesahin commented Apr 28, 2022

I renamed the directory and checked the links and redirects. I think this is ready to merge now. @jorgeorpinel @shcheklein

@iesahin iesahin merged commit e5c12a2 into master Apr 28, 2022
@iesahin iesahin deleted the iesahin/gs-reorg-3 branch April 28, 2022 15:15
Comment on lines +43 to 44
"^/doc/start/metrics-parameters-plots(/.*)?$ /doc/start/data-management/metrics-parameters-plots$1 302",
"^/doc/start/sharing-data-and-model-files$ /doc/start/data-and-model-versioning#storing-and-sharing 303",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated: I'm not sure why there are 302s and 303s in this file tbh. I think it should mostly be 302 except for a group near the top of utility redirects (e.g. data.dvc.org -> S3 bucket read)

@jorgeorpinel
Copy link
Contributor

p.s. @iterative/websites this needs deploying to prod please 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants