Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start: Add a parameters hidden section to experiments to merge params/metrics into experiments #3163

Merged
merged 8 commits into from
Jan 12, 2022

Conversation

iesahin
Copy link
Contributor

@iesahin iesahin commented Jan 10, 2022

This one adds a hidden section to explain parameters in more detail.

The final goal of this series is to merge "Params/Metrics/Plots" into the experiments trail.
Related #3051

@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-gs-expe-yfypcb January 10, 2022 14:45 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-gs-expe-yfypcb January 12, 2022 13:34 Inactive
@iesahin
Copy link
Contributor Author

iesahin commented Jan 12, 2022

Took care of the review points. PTAL. Thank you @jorgeorpinel @shcheklein

@jorgeorpinel
Copy link
Contributor

Thank you @iesahin !

@jorgeorpinel jorgeorpinel merged commit 8de2936 into master Jan 12, 2022
@jorgeorpinel jorgeorpinel deleted the iesahin/gs-experiments-add-params branch January 12, 2022 21:40
@jorgeorpinel
Copy link
Contributor

So can https://dvc.org/doc/start/metrics-parameters-plots be removed now?

@iesahin
Copy link
Contributor Author

iesahin commented Jan 21, 2022

So can dvc.org/doc/start/metrics-parameters-plots be removed now?

I think nope, not yet, after #3050 split and merged completely. These changes does not include visualization/plots.

iesahin added a commit that referenced this pull request Apr 11, 2022
…/metrics into experiments (#3163)

* added a hidden section

* Restyled by prettier (#3164)

Co-authored-by: Restyled.io <[email protected]>

* clarification

* stages -> experiments

* added that

* move example out of parens

* revised for command argument link to --set-param

* replaced "Here is..." with "Example"

Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com>
Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants